← 返回首页
Add some best practices by xfq · Pull Request #28 · w3c/string-search · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Add some best practices#28

Open
xfq wants to merge 10 commits into
gh-pagesfrom
xfq/best-practices
Open

Add some best practices#28
xfq wants to merge 10 commits into
gh-pagesfrom
xfq/best-practices

Conversation

Copy link
Copy Markdown
Member

xfq commented Jul 3, 2025

No description provided.

xfq requested a review from aphillips July 3, 2025 06:43
Copy link
Copy Markdown

netlify Bot commented Jul 3, 2025
edited
Loading

Deploy Preview for w3c-string-search ready!

Name Link
🔨 Latest commit f6bd4f2
🔍 Latest deploy log https://app.netlify.com/projects/w3c-string-search/deploys/69172a660f384f0008c76df3
😎 Deploy Preview https://deploy-preview-28--w3c-string-search.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread index.html Outdated Show resolved Hide resolved
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Comment thread index.html Outdated Show resolved Hide resolved
Comment thread index.html Outdated Show resolved Hide resolved
Comment thread index.html Outdated Show resolved Hide resolved
xfq and others added 4 commits November 12, 2025 09:27
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Copy link
Copy Markdown
Contributor

aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

some comments.

Note: best practices with no id attribute can't be externally linked, which is not ideal.

Comment thread index.html Outdated
<section id="caseVariation">
<h4>Case Folding</h4>

<p class="advisement">By default, string searching SHOULD be case-insensitive using Unicode's case-folding algorithms.</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This is complicated. Unicode's case-folding algorithms provide defaults, but, as we discuss later, there are at least some locale-specific foldings (which, I suppose, one could consider part of Unicode's case-folds......)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

What about something like this:

By default, string searching SHOULD be case-insensitive. Implementations SHOULD use Unicode's default case-folding algorithms, with locale-specific tailorings applied when the language context is known.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I think that's a good overall statement, but it's making the advisement do too many thing. Perhaps break it up like:

  • Allow users to switch between case-insensitive and case-sensitive searching
  • Make string searching case-insensitive by default
    • Use Unicode's default "full" case-fold for case-insensitive searching by default (where full is defined as common plus full mappings)
    • Optionally apply locale-specific tailorings of Unicode's "full" case-fold for case-insensitive searching when the language is known.
    • Use Turkic case folding where needed (more work needed for this one)

Comment thread index.html Outdated Show resolved Hide resolved
Comment thread index.html Outdated Show resolved Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.