← 返回首页
vdk-server: fix ingress settings by antoniivanov · Pull Request #3101 · vmware/versatile-data-kit · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

vdk-server: fix ingress settings#3101

Merged
antoniivanov merged 3 commits into
mainfrom
person/aivanov/dag
Feb 13, 2024
Merged

vdk-server: fix ingress settings#3101
antoniivanov merged 3 commits into
mainfrom
person/aivanov/dag

Conversation

antoniivanov commented Feb 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

In 5369fc6 ingress configuraiton was made more configurable but the defaults were removed and that broke vdk-server

Now installation fails with error like

-Stderr output: Error: INSTALLATION FAILED: release vdk failed, and has been uninstalled due to atomic being set: Ingress.extensions "vdk-pipelines-control-service" is invalid: spec: Invalid value: []networking.IngressRule(nil): either defaultBackend or rules must be specified

This change also

  • Addressed a TODO about command description
  • Added missing dependency.

Testing Done: vdk server --install succeeded locally. Separate PR is
working on adding automated tests.

antoniivanov force-pushed the person/aivanov/dag branch 5 times, most recently from 113cbd8 to 97ed5ac Compare February 11, 2024 23:21
antoniivanov marked this pull request as draft February 11, 2024 23:34
antoniivanov force-pushed the person/aivanov/dag branch 4 times, most recently from c4f99c9 to 06840cc Compare February 12, 2024 11:53
antoniivanov marked this pull request as ready for review February 12, 2024 11:55
DeltaMichael reviewed Feb 12, 2024
View reviewed changes
Comment thread projects/vdk-plugins/vdk-server/src/vdk/plugin/server/installer.py Show resolved Hide resolved
DeltaMichael reviewed Feb 12, 2024
View reviewed changes
Comment thread projects/vdk-plugins/vdk-server/src/vdk/plugin/server/server_plugin.py Outdated Show resolved Hide resolved
yonitoo approved these changes Feb 12, 2024
View reviewed changes

yonitoo left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Overall LGTM! I can now use a local server again :)

Comment thread projects/vdk-plugins/vdk-server/setup.py Show resolved Hide resolved
vdk-server: fix ingress settings …
4356490
In 5369fc6 ingress configuraiton was made more configurable but the defaults were removed and that broke vdk-server Now installation fails with error like -Stderr output: Error: INSTALLATION FAILED: release vdk failed, and has been uninstalled due to atomic being set: Ingress.extensions "vdk-pipelines-control-service" is invalid: spec: Invalid value: []networking.IngressRule(nil): either `defaultBackend` or `rules` must be specified Testing Done: vdk server --install succeeded locally. Separate PR is working on adding automated tests.
vdk-server: fix ingress settings …
2bf7b4c
In 5369fc6 ingress configuraiton was made more configurable but the defaults were removed and that broke vdk-server Now installation fails with error like -Stderr output: Error: INSTALLATION FAILED: release vdk failed, and has been uninstalled due to atomic being set: Ingress.extensions "vdk-pipelines-control-service" is invalid: spec: Invalid value: []networking.IngressRule(nil): either `defaultBackend` or `rules` must be specified Testing Done: vdk server --install succeeded locally. Separate PR is working on adding automated tests.
antoniivanov enabled auto-merge (squash) February 12, 2024 14:38
DeltaMichael self-requested a review February 13, 2024 08:43
antoniivanov merged commit 7f0ecd1 into main Feb 13, 2024
antoniivanov deleted the person/aivanov/dag branch February 13, 2024 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
yonitoo yonitoo approved these changes
DeltaMichael DeltaMichael approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.