← 返回首页
vdk-core: add is_default() function to config by DeltaMichael · Pull Request #3076 · vmware/versatile-data-kit · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

vdk-core: add is_default() function to config#3076

Merged
DeltaMichael merged 1 commit into
mainfrom
person/mdilyan/config-is-default
Feb 6, 2024
Merged

vdk-core: add is_default() function to config#3076
DeltaMichael merged 1 commit into
mainfrom
person/mdilyan/config-is-default

Conversation

DeltaMichael commented Feb 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why?

There are cases where we want to know we're using the default value for a config option. One such case is configuration presets

#3055

What?

Add is_default() to the config object.

How was this tested?

Unit tests

What kind of change is this?

Feature/non-breaking

DeltaMichael force-pushed the person/mdilyan/config-is-default branch from 6cd3382 to 0e32258 Compare February 5, 2024 12:01
DeltaMichael mentioned this pull request Feb 5, 2024
Merged
antoniivanov suggested changes Feb 6, 2024
View reviewed changes
Comment thread examples/confluence-reader/confluence_document.py Show resolved Hide resolved
Comment thread projects/vdk-core/src/vdk/internal/core/config.py Outdated Show resolved Hide resolved
DeltaMichael force-pushed the person/mdilyan/config-is-default branch 3 times, most recently from 8c69032 to 223b807 Compare February 6, 2024 13:51
antoniivanov reviewed Feb 6, 2024
View reviewed changes
Comment thread projects/vdk-core/src/vdk/internal/core/config.py Outdated Show resolved Hide resolved
vdk-core: add is_default() function to config …
0e7073e
Why? There are cases where we want to know we're using the default value for a config option. One such case is configuration presets #3055 What? Add is_default() to the config object. How was this tested? Unit tests What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael force-pushed the person/mdilyan/config-is-default branch from 223b807 to 0e7073e Compare February 6, 2024 13:59
DeltaMichael merged commit b3e7b45 into main Feb 6, 2024
DeltaMichael deleted the person/mdilyan/config-is-default branch February 6, 2024 14:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
antoniivanov antoniivanov approved these changes
gabrielgeorgiev1 gabrielgeorgiev1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.