← 返回首页
vdk-core: Adopt 'method' argument in pre-process plugins by doks5 · Pull Request #3074 · vmware/versatile-data-kit · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

vdk-core: Adopt 'method' argument in pre-process plugins#3074

Merged
dakodakov merged 5 commits into
mainfrom
person/andonova/ingester-base
Feb 19, 2024
Merged

vdk-core: Adopt 'method' argument in pre-process plugins#3074
dakodakov merged 5 commits into
mainfrom
person/andonova/ingester-base

Conversation

doks5 commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

As part of 03dde45, the pre_ingest_process and post_ingest_process hooks of the IIngesterPlugin were updated to pass the ingest method to user-implemented ingestion plugins.

This change updates the IngesterBase to pass the method argument from the ingested payloads to the pre_ingest_process and post_ingest_process hooks of the registered ingester plugins.

Testing Done: Updated tests

vdk-core: Adopt 'method' argument in pre-process plugins …
0570e6a
As part of 03dde45, the `pre_ingest_process` and `post_ingest_process` hooks of the IIngesterPlugin were updated to pass the ingest method to user-implemented ingestion plugins. This change updates the IngesterBase to pass the `method` argument from the ingested payloads to the `pre_ingest_process` and `post_ingest_process` hooks of the registered ingester plugins. Testing Done: Updated tests Signed-off-by: Andon Andonov <andonova@vmware.com>
dakodakov approved these changes Feb 14, 2024
View reviewed changes

dakodakov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

good to go.

dakodakov merged commit cd718ba into main Feb 19, 2024
dakodakov deleted the person/andonova/ingester-base branch February 19, 2024 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dakodakov dakodakov approved these changes
+1 more reviewer
antoniivanov antoniivanov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.