← 返回首页
Support mobile, update zh-CN locales by guyskk · Pull Request #488 · stringer-rss/stringer · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Support mobile, update zh-CN locales#488

Open
guyskk wants to merge 1 commit into
stringer-rss:mainfrom
guyskk:mobile
Open

Support mobile, update zh-CN locales#488
guyskk wants to merge 1 commit into
stringer-rss:mainfrom
guyskk:mobile

Conversation

guyskk commented Sep 2, 2018

Copy link
Copy Markdown
Contributor

Before:


After:


guyskk commented Sep 2, 2018

Copy link
Copy Markdown
Contributor Author

I don't have permission to add translation in LocaleApp, how to participate in?

duenni commented Sep 2, 2018

Copy link
Copy Markdown

Will this close #464?

guyskk commented Sep 3, 2018

Copy link
Copy Markdown
Contributor Author

@duenni No, but I can fix it in next commit.

If you device has very small screen(eg: IPhone 4), the layout may broken.

When screen is 375x667 pixel:

When screen is 320x480 pixel:

guyskk commented Sep 3, 2018

Copy link
Copy Markdown
Contributor Author

@duenni I just blamed the stylesheets source code, it shows the font-size not change in the last 5 years.
So it's not caused by stringer updates, did you tried other browers and devices?

duenni commented Sep 3, 2018

Copy link
Copy Markdown

No, I did not try other devices. It's an iPhone SE, resolution should be 1136 x 640 px.

Copy link
Copy Markdown
Collaborator

@guyskk I know it's been a couple of years, but are you still available to work on this? If so, I think it would be good to break up into separate PRs. One for the translations, one for the layout cleanups, and one for Turbolinks. I'm a little concerned about Turbolinks in particular, as that can cause issues depending on how the JavaScript is set up.

guyskk commented Feb 21, 2021

Copy link
Copy Markdown
Contributor Author

Hi @mockdeep, I didn't use stringer for a long time, and I have build another RSS reader https://github.com/anyant/rssant .

Please feel free to use my code and commits if you need.

Copy link
Copy Markdown
Collaborator

@guyskk okay, I'll handle it, then. Thanks so much for contributing!

Copy link
Copy Markdown
Contributor

@mockdeep would love to have those css fixes merged. Should I take over the fixing of this pr?

Copy link
Copy Markdown
Collaborator

@bitboxer that would be great! If you want to separate out the CSS changes, I'll be happy to review them and get them merged.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.