← 返回首页
Support derived Animate classes in order to use the same axes. by tahsinkose · Pull Request #50 · rai-opensource/spatialmath-python · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Support derived Animate classes in order to use the same axes.#50

Open
tahsinkose wants to merge 1 commit into
rai-opensource:masterfrom
tahsinkose:master
Open

Support derived Animate classes in order to use the same axes.#50
tahsinkose wants to merge 1 commit into
rai-opensource:masterfrom
tahsinkose:master

Conversation

tahsinkose commented Mar 21, 2022

Copy link
Copy Markdown

Hello there,

I've been using the MATLAB version of these nice toolboxes and just recently finally had a use-case to migrate to Python. I needed to visualize multiple frames in a single animation view. In order to do that, I have to derive from base.animate.Animate and adjust some of the internal data structures. In order to use the same ax as base.animate.Animate does, however, I had to clone this repo and make this change so that all derived classes receive the exact same treatment with the base class.

tahsinkose commented Apr 7, 2022

Copy link
Copy Markdown
Author

@jhavl this is a rather simple yet capable improvement that provides trivial extensibility of Animate classes. Could you please give it a quick look and merge? 🙏🏼

Cc. @petercorke

petercorke commented Apr 8, 2022

Copy link
Copy Markdown
Collaborator

Looks great! I'll have a look at the change on the weekend. There's more I'd like to do with animations but this seems like a win. Thx for your interest

tahsinkose commented Nov 6, 2022

Copy link
Copy Markdown
Author

@petercorke friendly ping 🙂

tahsinkose commented Aug 27, 2024

Copy link
Copy Markdown
Author

Another friendly ping for @jhavl and @myeatman-bdai. This is rather a simple improvement, thus should not take too much of your time. PTAL 🙏🏼

tahsinkose commented Apr 3, 2026

Copy link
Copy Markdown
Author

@baxelrod-bdai could you check please? It is a pretty small PR

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

petercorke Awaiting requested review from petercorke petercorke is a code owner
jhavl Awaiting requested review from jhavl
myeatman-bdai Awaiting requested review from myeatman-bdai myeatman-bdai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.