Refactor parse_xml function to handle external target references (Issue #1349)#1350

al-rahul

The added code checks if self.target_ref exists and if it starts with a "#", which is a common way to denote external references. If both conditions are met, the method returns RTM.EXTERNAL, indicating that the target reference is external.

This change improves the robustness of our code by correctly handling and classifying external references. This will prevent potential errors or unexpected behavior when encountering such references.

SebG-js

Hello
I met this issue.
It could be interesting to get this fix in the main branch.

    def getinfo(self, name):
        """Return the instance of ZipInfo given 'name'."""
        info = self.NameToInfo.get(name)
        if info is None:
>           raise KeyError(
                'There is no item named %r in the archive' % name)
E           KeyError: "There is no item named 'word/#schémaglobal' in the archive"

schwaxpl

Hello
I met this issue.
Would be great to apply the known fix :)

SebG-js

Hello @al-rahul
Thank you for the fix.
Could you resolve the conflicts ?
I am interested by the fix in the master branch.

al-rahul

Hello @al-rahul Thank you for the fix. Could you resolve the conflicts ? I am interested by the fix in the master branch.

I've made a pull request already, but the repo owner seems to be inactive and hasn't touched it in more than a year.

SebG-js

Hello @scanny
@al-rahul proposed an interesting fix.
Are you an active contributor of this project ?
Could you help us ?

Maybe the repo owner can add new active contributors ?

TommasoPetrolito

+1 I also faced a similar issue and I tried the change of this PR and it works. Please, it would be very useful if the proposed PR could get merged.

TommasoPetrolito

@scanny you appear to be the #1 contributor in this repository, can you please have a look to this PR and let us know if this can get merged?

TommasoPetrolito

@ondrej-111 if @scanny can't, can you maybe help with this?

TommasoPetrolito

Possible temporary fixes, in your requirements.txt instead of python-docx==1.1.2 or similar, use instead:

OPTION A:
python-docx @ git+https://github.com/al-rahul/python-docx.git@4ebb3ac
Thank you @al-rahul

OPTION B:
python-docx @ git+https://github.com/TommasoPetrolito/python-docx.git@66fa597
This last one is a merge into the current master branch as per the latest version available (including solved conflicts)

Refactor parse_xml function to handle external target references in C… …

4ebb3ac

…T_Relationship class

SebG-js mentioned this pull request Mar 17, 2025

Unable to read docx containing pictures linking to internal bookmarks: KeyError: "There is no item named 'word/#MyBookmark' in the archive" #902

Open

TommasoPetrolito mentioned this pull request Sep 10, 2025

Refactor parse_xml function to handle external target references (Issue #1349) (old PR #1350) #1518

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor parse_xml function to handle external target references (Issue #1349)#1350