← 返回首页
Replace black and isort with ruff by egeakman · Pull Request #23 · python-docs-translations/python-docs-bootstrapper · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Replace black and isort with ruff#23

Merged
egeakman merged 1 commit into
mainfrom
ruff
Jun 7, 2025
Merged

Replace black and isort with ruff#23
egeakman merged 1 commit into
mainfrom
ruff

Conversation

Copy link
Copy Markdown
Member

egeakman commented Jun 2, 2025

Closes #21

egeakman self-assigned this Jun 2, 2025
egeakman requested review from hugovk and rffontenelle June 3, 2025 07:49
Hide details View details egeakman merged commit bf0b8ea into main Jun 7, 2025
56 checks passed
egeakman deleted the ruff branch June 7, 2025 19:48
hugovk reviewed Jun 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Post-merge review (I was travelling last week): looks good :)

Only suggestions I would have made:

  • keep check-toml
  • put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note at https://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using --fix
  • move the Ruff args out of pre-commit config and into pyproject.toml, so they are available when running Ruff outside of pre-commit

But not a big deal.

egeakman mentioned this pull request Jun 8, 2025
Open
Copy link
Copy Markdown
Member Author

egeakman commented Jun 8, 2025 •
edited
Loading

Post-merge review (I was travelling last week): looks good :)

Only suggestions I would have made:

  • keep check-toml
  • put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note at https://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using --fix
  • move the Ruff args out of pre-commit config and into pyproject.toml, so they are available when running Ruff outside of pre-commit

But not a big deal.

Thank you! Created a new issue (#24) to track these!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rffontenelle Awaiting requested review from rffontenelle

1 more reviewer

hugovk hugovk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

egeakman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace black and isort with ruff

2 participants

Footer

© 2026 GitHub, Inc.