| cmake_minimum_required(VERSION 3.3) # Version introducing CROSSCOMPILING_EMULATOR | ||
| endif() | ||
|
|
||
| if(MSVC) |
There was a problem hiding this comment.
Should be WIN32, that way building in Debug on windows using Ninja will work as expected.
Sorry, something went wrong.
| add_python_extension(_tracemalloc BUILTIN REQUIRES IS_PY3 SOURCES hashtable.c _tracemalloc.c) | ||
| add_python_extension(_weakref BUILTIN REQUIRES IS_PY3 SOURCES _weakref.c) | ||
| math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}") | ||
| if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "Debug") |
There was a problem hiding this comment.
Should probably be something like :
That said, the approach should still be tweaked to handle the case of Visual Studio where CMAKE_CONFIGURATION_TYPES is defined
Sorry, something went wrong.
There was a problem hiding this comment.
@dbrnz I had an other look at this, and if Py_LIMITED_API must not be defined when doing Debug build, relying on a newer version of CMake supporting generator expression would be the way to go.
That way, we will be able to do something like this:
Sorry, something went wrong.
Supersede PR #151