|
@jordanSu, would you be interested in reviewing this PR? |
Sorry, something went wrong.
|
@mattwang44 sorry for late reply, sure let me review this. |
Sorry, something went wrong.
|
@jordanSu I've sent an invitation for joining this project (in order to set you as a reviewer) a while ago. Remember to confirm it (link). @mattwang44 sorry for missing the invitation, I found the link has expired, could you kindly send me a new one? Thanks a lot! |
Sorry, something went wrong.
|
@jordanSu |
Sorry, something went wrong.
|
@mattwang44 Sorry for late, I might not be able to review it recently, I think it would be better to assign this to another reviewer. |
Sorry, something went wrong.
|
@jordanSu NP! Thanks for the efforts. Look forward to seeing your contribution again! |
Sorry, something went wrong.
There was a problem hiding this comment.
幫忙 review 一下。
建議僅供參考,大多是閱讀流暢度的小建議,都可以再討論。 😃
Sorry, something went wrong.
| "A queue class for use in a multi-processing (rather than multi-threading) " | ||
| "context." | ||
| msgstr "" | ||
| msgstr "用於多工(而非多執行緒)上下文的佇列 class。" |
There was a problem hiding this comment.
| msgstr "用於多工(而非多執行緒)上下文的佇列 class。" | |
| msgstr "用於多元處理(而非多執行緒)上下文的佇列 class。" |
Reference: 多元處理 wiki
Sorry, something went wrong.
There was a problem hiding this comment.
process 一詞目前多翻譯為行程
| msgstr "用於多工(而非多執行緒)上下文的佇列 class。" | |
| msgstr "用於多行程處理 (multi-processing)(而非多執行緒)情境 (context) 的佇列 class。" |
Sorry, something went wrong.
|
幫忙 review 一下。 建議僅供參考,大多是閱讀流暢度的小建議,都可以再討論。 😃 感謝 Steven!這個 PR 我會接手處理 |
Sorry, something went wrong.
|
Thanks for the review from Steven. I'm just updated the file from the review. Please have a look! |
Sorry, something went wrong.
There was a problem hiding this comment.
前面 Steven 的 comment 還有一些沒修掉,要再請你檢查一下 🙏🏽
Sorry, something went wrong.
|
@allen91wu 還差 FIFO 那段 (../../library/queue.rst:37) 的 消耗完 要改成 消耗 |
Sorry, something went wrong.
|
@mattwang44 感謝提醒,已經 push 修正過後的版本 |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
看 @StevenHsuYL 有沒有興趣再檢查一下~
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM (with optional editing later). 👍
Sorry, something went wrong.
|
@mattwang44 @StevenHsuYL |
Sorry, something went wrong.
|
@mattwang44 @StevenHsuYL I’m just updated the file from Steven’s suggestion. Please have a look. line 360-371 好像重複貼上了,再麻煩修改一下,謝謝! |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Thanks for the great work!
Sorry, something went wrong.
resolve #181
Preview