← 返回首页
PEP 440: regex should not permit Unicode [Nd] characters by RazerM · Pull Request #966 · python/peps · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

PEP 440: regex should not permit Unicode [Nd] characters#966

Merged
ncoghlan merged 2 commits into
python:masterfrom
RazerM:pep-440-regex
Apr 7, 2019
Merged

PEP 440: regex should not permit Unicode [Nd] characters#966
ncoghlan merged 2 commits into
python:masterfrom
RazerM:pep-440-regex

Conversation

RazerM commented Mar 30, 2019

Copy link
Copy Markdown
Contributor

Example of old behaviour:

>>> is_canonical('1٤') True

the-knights-who-say-ni commented Mar 30, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

brettcannon requested review from dstufft and ncoghlan April 1, 2019 19:54
ncoghlan approved these changes Apr 7, 2019
View reviewed changes

ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Good catch - this was the actual expected behaviour, but the PEP didn't say it explicitly (it was only implied by the version parsing regex in Appendix B)

ncoghlan merged commit 1dd991e into python:master Apr 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncoghlan ncoghlan approved these changes
dstufft Awaiting requested review from dstufft

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.