← 返回首页
gh-60203: Always pass True/False as boolean arguments in tests by serhiy-storchaka · Pull Request #99983 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-60203: Always pass True/False as boolean arguments in tests#99983

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:bool-cleanup2
Dec 4, 2022
Merged

gh-60203: Always pass True/False as boolean arguments in tests#99983
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:bool-cleanup2

Conversation

serhiy-storchaka commented Dec 4, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Unless we explicitly test non-bool values.

serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Dec 4, 2022
bedevere-bot mentioned this pull request Dec 4, 2022
Closed
serhiy-storchaka merged commit 76f43fc into python:main Dec 4, 2022

miss-islington commented Dec 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

serhiy-storchaka deleted the bool-cleanup2 branch December 4, 2022 12:29

miss-islington commented Dec 4, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 76f43fc09af29401cc0cec7710b03e4dbf8a4578 3.10

bedevere-bot commented Dec 4, 2022

Copy link
Copy Markdown

GH-99986 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 4, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2022
pythongh-60203: Always pass True/False as boolean arguments in tests (p… …
6a0c576
…ythonGH-99983) Unless we explicitly test non-bool values. (cherry picked from commit 76f43fc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 4, 2022
[3.10] pythongh-60203: Always pass True/False as boolean arguments in… …
f279305
… tests (pythonGH-99983) Unless we explicitly test non-bool values.. (cherry picked from commit 76f43fc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka mentioned this pull request Dec 4, 2022
Merged

bedevere-bot commented Dec 4, 2022

Copy link
Copy Markdown

GH-99989 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 4, 2022
miss-islington added a commit that referenced this pull request Dec 4, 2022
gh-60203: Always pass True/False as boolean arguments in tests (GH-99983 …
7aa87bb
) Unless we explicitly test non-bool values. (cherry picked from commit 76f43fc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Dec 4, 2022
[3.10] gh-60203: Always pass True/False as boolean arguments in tests (… …
ac78128
…GH-99983) (GH-99989) Unless we explicitly test non-bool values. (cherry picked from commit 76f43fc)
serhiy-storchaka removed their assignment Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead Awaiting requested review from gpshead gpshead is a code owner
1st1 Awaiting requested review from 1st1
asvetlov Awaiting requested review from asvetlov
gvanrossum Awaiting requested review from gvanrossum
kumaraditya303 Awaiting requested review from kumaraditya303

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.