← 返回首页
gh-93649: Split watcher API tests from _testcapimodule.c by erlend-aasland · Pull Request #99532 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-93649: Split watcher API tests from _testcapimodule.c#99532

Merged
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:split-testcapi/watchers
Nov 16, 2022
Merged

gh-93649: Split watcher API tests from _testcapimodule.c#99532
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:split-testcapi/watchers

Conversation

erlend-aasland commented Nov 16, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland requested a review from a team as a code owner November 16, 2022 13:11
bedevere-bot mentioned this pull request Nov 16, 2022
Open
sobolevn reviewed Nov 16, 2022
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I think we can also move class TestDictWatchers(unittest.TestCase): from test_capi/test_misc.py to its own python file: test_capi/test_dict_watchers.py

erlend-aasland commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

I think we can also move class TestDictWatchers(unittest.TestCase): from test_capi/test_misc.py to its own python file: test_capi/test_dict_watchers.py

That's a good idea.

vstinner reviewed Nov 16, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

First, I hesitated to suggest "dict" instead of "watchers", but it seems like there are many tests on dict watchers, so it's worth it to have separated files.

Can you rename watchers.c/py to dict_watchers.c/py?

I'm fine to leave the 4 other "dict" functions in _testcapi for now:

{"test_dict_iteration", test_dict_iteration, METH_NOARGS}, {"dict_getitem_knownhash", dict_getitem_knownhash, METH_VARARGS}, {"dict_get_version", dict_get_version, METH_VARARGS}, {"clear_managed_dict", clear_managed_dict, METH_O, NULL},

erlend-aasland commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

But there are also type watchers, and soon also function watchers. I figured all of these watcher APIs could live in the same place. Perhaps it will be too scattered with a new pair of files for each of these.

vstinner commented Nov 16, 2022

Copy link
Copy Markdown
Member

Oh. I didn't notice that watchers are on different things. I was only aware of dict watchers.

vstinner commented Nov 16, 2022

Copy link
Copy Markdown
Member

In this case, "watchers" is a perfect name.

erlend-aasland merged commit 51d1035 into python:main Nov 16, 2022
erlend-aasland deleted the split-testcapi/watchers branch November 16, 2022 19:13

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 3.x has failed when building commit 51d1035.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/179/builds/3428) and take a look at the build logs.
  4. Check if the failure is related to this commit (51d1035) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/179/builds/3428

Failed tests:

  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 29, done.�[K remote: Counting objects: 3% (1/29)�[K remote: Counting objects: 6% (2/29)�[K remote: Counting objects: 10% (3/29)�[K remote: Counting objects: 13% (4/29)�[K remote: Counting objects: 17% (5/29)�[K remote: Counting objects: 20% (6/29)�[K remote: Counting objects: 24% (7/29)�[K remote: Counting objects: 27% (8/29)�[K remote: Counting objects: 31% (9/29)�[K remote: Counting objects: 34% (10/29)�[K remote: Counting objects: 37% (11/29)�[K remote: Counting objects: 41% (12/29)�[K remote: Counting objects: 44% (13/29)�[K remote: Counting objects: 48% (14/29)�[K remote: Counting objects: 51% (15/29)�[K remote: Counting objects: 55% (16/29)�[K remote: Counting objects: 58% (17/29)�[K remote: Counting objects: 62% (18/29)�[K remote: Counting objects: 65% (19/29)�[K remote: Counting objects: 68% (20/29)�[K remote: Counting objects: 72% (21/29)�[K remote: Counting objects: 75% (22/29)�[K remote: Counting objects: 79% (23/29)�[K remote: Counting objects: 82% (24/29)�[K remote: Counting objects: 86% (25/29)�[K remote: Counting objects: 89% (26/29)�[K remote: Counting objects: 93% (27/29)�[K remote: Counting objects: 96% (28/29)�[K remote: Counting objects: 100% (29/29)�[K remote: Counting objects: 100% (29/29), done.�[K remote: Compressing objects: 6% (1/15)�[K remote: Compressing objects: 13% (2/15)�[K remote: Compressing objects: 20% (3/15)�[K remote: Compressing objects: 26% (4/15)�[K remote: Compressing objects: 33% (5/15)�[K remote: Compressing objects: 40% (6/15)�[K remote: Compressing objects: 46% (7/15)�[K remote: Compressing objects: 53% (8/15)�[K remote: Compressing objects: 60% (9/15)�[K remote: Compressing objects: 66% (10/15)�[K remote: Compressing objects: 73% (11/15)�[K remote: Compressing objects: 80% (12/15)�[K remote: Compressing objects: 86% (13/15)�[K remote: Compressing objects: 93% (14/15)�[K remote: Compressing objects: 100% (15/15)�[K remote: Compressing objects: 100% (15/15), done.�[K remote: Total 16 (delta 13), reused 3 (delta 1), pack-reused 0�[K From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: checking out '51d10354f43c708ebbb7d13c14bf0ea52b28489e'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example: git checkout -b new_branch_name HEAD is now at 51d1035... gh-93649: Split watcher API tests from _testcapimodule.c (#99532) Switched to and reset branch 'main' In file included from ./Include/internal/pycore_opcode.h:13:0, from Python/ceval.c:19: Python/ceval.c: In function ‘lltrace_instruction’: Python/ceval.c:146:17: warning: comparison is always false due to limited range of data type [-Wtype-limits] if (HAS_ARG((int)_PyOpcode_Deopt[opcode])) { ^ ./Include/opcode.h:236:33: note: in definition of macro ‘IS_PSEUDO_OPCODE’ #define IS_PSEUDO_OPCODE(op) (((op) >= MIN_PSEUDO_OPCODE) && ((op) <= MAX_PSEUDO_OPCODE)) ^ Python/ceval.c:146:9: note: in expansion of macro ‘HAS_ARG’ if (HAS_ARG((int)_PyOpcode_Deopt[opcode])) { ^ Python/ceval.c:146:17: warning: comparison is always false due to limited range of data type [-Wtype-limits] if (HAS_ARG((int)_PyOpcode_Deopt[opcode])) { ^ ./Include/opcode.h:198:10: note: in definition of macro ‘HAS_ARG’ || ((op) == JUMP) \ ^ Python/ceval.c:146:17: warning: comparison is always false due to limited range of data type [-Wtype-limits] if (HAS_ARG((int)_PyOpcode_Deopt[opcode])) { ^ ./Include/opcode.h:199:10: note: in definition of macro ‘HAS_ARG’ || ((op) == JUMP_NO_INTERRUPT) \ ^ Python/ceval.c:146:17: warning: comparison is always false due to limited range of data type [-Wtype-limits] if (HAS_ARG((int)_PyOpcode_Deopt[opcode])) { ^ ./Include/opcode.h:200:10: note: in definition of macro ‘HAS_ARG’ || ((op) == LOAD_METHOD) \ ^ Fatal Python error: Segmentation fault Current thread 0x000003ffb3f7f910 (most recent call first): <no Python frame> Thread 0x000003ffbc377700 (most recent call first): File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_threading.py", line 847 in test_frame_tstate_tracing File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/case.py", line 579 in _callTestMethod File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/case.py", line 623 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/case.py", line 678 in __call__ File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/suite.py", line 122 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/suite.py", line 122 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/suite.py", line 122 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/unittest/runner.py", line 208 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/support/__init__.py", line 1100 in _run_suite File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/support/__init__.py", line 1226 in run_unittest File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/runtest.py", line 281 in _test_module File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/runtest.py", line 317 in _runtest_inner2 File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/runtest.py", line 360 in _runtest_inner File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/runtest.py", line 235 in _runtest File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/runtest.py", line 265 in runtest File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/main.py", line 352 in rerun_failed_tests File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/main.py", line 754 in _main File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/main.py", line 709 in main File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/libregrtest/main.py", line 773 in main File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/__main__.py", line 2 in <module> File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/runpy.py", line 88 in _run_code File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/runpy.py", line 198 in _run_module_as_main Extension modules: _testcapi (total: 1) make: *** [buildbottest] Segmentation fault Cannot open file '/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/test-results.xml' for upload

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO 3.x has failed when building commit 51d1035.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/402/builds/3384) and take a look at the build logs.
  4. Check if the failure is related to this commit (51d1035) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/402/builds/3384

Failed tests:

  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 29, done.�[K remote: Counting objects: 3% (1/29)�[K remote: Counting objects: 6% (2/29)�[K remote: Counting objects: 10% (3/29)�[K remote: Counting objects: 13% (4/29)�[K remote: Counting objects: 17% (5/29)�[K remote: Counting objects: 20% (6/29)�[K remote: Counting objects: 24% (7/29)�[K remote: Counting objects: 27% (8/29)�[K remote: Counting objects: 31% (9/29)�[K remote: Counting objects: 34% (10/29)�[K remote: Counting objects: 37% (11/29)�[K remote: Counting objects: 41% (12/29)�[K remote: Counting objects: 44% (13/29)�[K remote: Counting objects: 48% (14/29)�[K remote: Counting objects: 51% (15/29)�[K remote: Counting objects: 55% (16/29)�[K remote: Counting objects: 58% (17/29)�[K remote: Counting objects: 62% (18/29)�[K remote: Counting objects: 65% (19/29)�[K remote: Counting objects: 68% (20/29)�[K remote: Counting objects: 72% (21/29)�[K remote: Counting objects: 75% (22/29)�[K remote: Counting objects: 79% (23/29)�[K remote: Counting objects: 82% (24/29)�[K remote: Counting objects: 86% (25/29)�[K remote: Counting objects: 89% (26/29)�[K remote: Counting objects: 93% (27/29)�[K remote: Counting objects: 96% (28/29)�[K remote: Counting objects: 100% (29/29)�[K remote: Counting objects: 100% (29/29), done.�[K remote: Compressing objects: 6% (1/15)�[K remote: Compressing objects: 13% (2/15)�[K remote: Compressing objects: 20% (3/15)�[K remote: Compressing objects: 26% (4/15)�[K remote: Compressing objects: 33% (5/15)�[K remote: Compressing objects: 40% (6/15)�[K remote: Compressing objects: 46% (7/15)�[K remote: Compressing objects: 53% (8/15)�[K remote: Compressing objects: 60% (9/15)�[K remote: Compressing objects: 66% (10/15)�[K remote: Compressing objects: 73% (11/15)�[K remote: Compressing objects: 80% (12/15)�[K remote: Compressing objects: 86% (13/15)�[K remote: Compressing objects: 93% (14/15)�[K remote: Compressing objects: 100% (15/15)�[K remote: Compressing objects: 100% (15/15), done.�[K remote: Total 16 (delta 13), reused 3 (delta 1), pack-reused 0�[K From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: checking out '51d10354f43c708ebbb7d13c14bf0ea52b28489e'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example: git checkout -b new_branch_name HEAD is now at 51d1035... gh-93649: Split watcher API tests from _testcapimodule.c (#99532) Switched to and reset branch 'main' Objects/frameobject.c: In function ‘frame_init_get_vars’: Objects/frameobject.c:1121:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] if (!(lasti < 0 && _Py_OPCODE(_PyCode_CODE(co)[0]) == COPY_FREE_VARS ^ Objects/obmalloc.c:776:1: warning: always_inline function might not be inlinable [-Wattributes] arena_map_get(pymem_block *p, int create) ^ Fatal Python error: Segmentation fault Current thread 0x000003ff7dffb910 (most recent call first): <no Python frame> Thread 0x000003ffbc877700 (most recent call first): File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_threading.py", line 847 in test_frame_tstate_tracing File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/case.py", line 579 in _callTestMethod File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/case.py", line 623 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/case.py", line 678 in __call__ File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/suite.py", line 122 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/suite.py", line 122 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/suite.py", line 122 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/unittest/runner.py", line 208 in run File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/support/__init__.py", line 1100 in _run_suite File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/support/__init__.py", line 1226 in run_unittest File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/runtest.py", line 281 in _test_module File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/runtest.py", line 317 in _runtest_inner2 File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/runtest.py", line 360 in _runtest_inner File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/runtest.py", line 235 in _runtest File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/runtest.py", line 265 in runtest File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/main.py", line 352 in rerun_failed_tests File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/main.py", line 754 in _main File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/main.py", line 709 in main File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/libregrtest/main.py", line 773 in main File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/__main__.py", line 2 in <module> File "<frozen runpy>", line 88 in _run_code File "<frozen runpy>", line 198 in _run_module_as_main Extension modules: _testcapi (total: 1) make: *** [buildbottest] Segmentation fault Cannot open file '/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/test-results.xml' for upload

sobolevn commented Nov 16, 2022

Copy link
Copy Markdown
Member

I've opened #99544 about this crash.

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable 3.x has failed when building commit 51d1035.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/543/builds/2740) and take a look at the build logs.
  4. Check if the failure is related to this commit (51d1035) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/543/builds/2740

Failed tests:

  • test_capi
  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 29, done. remote: Counting objects: 3% (1/29) remote: Counting objects: 6% (2/29) remote: Counting objects: 10% (3/29) remote: Counting objects: 13% (4/29) remote: Counting objects: 17% (5/29) remote: Counting objects: 20% (6/29) remote: Counting objects: 24% (7/29) remote: Counting objects: 27% (8/29) remote: Counting objects: 31% (9/29) remote: Counting objects: 34% (10/29) remote: Counting objects: 37% (11/29) remote: Counting objects: 41% (12/29) remote: Counting objects: 44% (13/29) remote: Counting objects: 48% (14/29) remote: Counting objects: 51% (15/29) remote: Counting objects: 55% (16/29) remote: Counting objects: 58% (17/29) remote: Counting objects: 62% (18/29) remote: Counting objects: 65% (19/29) remote: Counting objects: 68% (20/29) remote: Counting objects: 72% (21/29) remote: Counting objects: 75% (22/29) remote: Counting objects: 79% (23/29) remote: Counting objects: 82% (24/29) remote: Counting objects: 86% (25/29) remote: Counting objects: 89% (26/29) remote: Counting objects: 93% (27/29) remote: Counting objects: 96% (28/29) remote: Counting objects: 100% (29/29) remote: Counting objects: 100% (29/29), done. remote: Compressing objects: 6% (1/15) remote: Compressing objects: 13% (2/15) remote: Compressing objects: 20% (3/15) remote: Compressing objects: 26% (4/15) remote: Compressing objects: 33% (5/15) remote: Compressing objects: 40% (6/15) remote: Compressing objects: 46% (7/15) remote: Compressing objects: 53% (8/15) remote: Compressing objects: 60% (9/15) remote: Compressing objects: 66% (10/15) remote: Compressing objects: 73% (11/15) remote: Compressing objects: 80% (12/15) remote: Compressing objects: 86% (13/15) remote: Compressing objects: 93% (14/15) remote: Compressing objects: 100% (15/15) remote: Compressing objects: 100% (15/15), done. remote: Total 16 (delta 13), reused 3 (delta 1), pack-reused 0 From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: switching to '51d10354f43c708ebbb7d13c14bf0ea52b28489e'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c <new-branch-name> Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at 51d10354f4 gh-93649: Split watcher API tests from _testcapimodule.c (#99532) Switched to and reset branch 'main' Fatal Python error: Segmentation fault Current thread 0x00007f2369ffb640 (most recent call first): <no Python frame> Thread 0x00007f23af6c2b80 (most recent call first): File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/test_threading.py", line 847 in test_frame_tstate_tracing File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/case.py", line 579 in _callTestMethod File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/case.py", line 623 in run File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/case.py", line 678 in __call__ File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/suite.py", line 122 in run File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/suite.py", line 122 in run File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/suite.py", line 122 in run File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/unittest/runner.py", line 208 in run File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/support/__init__.py", line 1100 in _run_suite File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/support/__init__.py", line 1226 in run_unittest File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/runtest.py", line 281 in _test_module File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/runtest.py", line 317 in _runtest_inner2 File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/runtest.py", line 360 in _runtest_inner File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/runtest.py", line 235 in _runtest File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/runtest.py", line 265 in runtest File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/main.py", line 352 in rerun_failed_tests File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/main.py", line 754 in _main File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/main.py", line 709 in main File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/libregrtest/main.py", line 773 in main File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/__main__.py", line 2 in <module> File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/runpy.py", line 88 in _run_code File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/runpy.py", line 198 in _run_module_as_main Extension modules: _testcapi (total: 1) make: *** [Makefile:1891: buildbottest] Segmentation fault (core dumped) Cannot open file '/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/build_oot/test-results.xml' for upload

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan 3.x has failed when building commit 51d1035.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/582/builds/2353) and take a look at the build logs.
  4. Check if the failure is related to this commit (51d1035) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/582/builds/2353

Failed tests:

  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan/build/Lib/threading.py", line 1052, in _bootstrap_inner self.run() File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan/build/Lib/threading.py", line 989, in run self._target(*self._args, **self._kwargs) File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan/build/Lib/test/test_threading.py", line 1172, in do_fork_and_wait support.wait_process(pid, exitcode=50) File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan/build/Lib/test/support/__init__.py", line 2125, in wait_process raise AssertionError(f"process {pid} is still running " AssertionError: process 565453 is still running after 525.4 seconds

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
sobolevn sobolevn left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.