← 返回首页
gh-93649: Split pytime and datetime tests from _testcapimodule.c by erlend-aasland · Pull Request #99494 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-93649: Split pytime and datetime tests from _testcapimodule.c#99494

Merged
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:testcapi/extract-time-stuff
Nov 15, 2022
Merged

gh-93649: Split pytime and datetime tests from _testcapimodule.c#99494
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:testcapi/extract-time-stuff

Conversation

erlend-aasland commented Nov 14, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Nov 14, 2022
Open
vstinner reviewed Nov 14, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

What do you think about separating "time" and "datetime" tests in two files?

The _PyTime_ObjectToTimespec() and _PyTime APIs are not directly related to the datetime module.

erlend-aasland commented Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

What do you think about separating "time" and "datetime" tests in two files?

The _PyTime_ObjectToTimespec() and _PyTime APIs are not directly related to the datetime module.

Sounds good to me :)

erlend-aasland requested a review from a team as a code owner November 14, 2022 22:32
erlend-aasland changed the title gh-93649: Split time tests from _testcapimodule.c gh-93649: Split pytime and datetime tests from _testcapimodule.c Nov 14, 2022
vstinner approved these changes Nov 14, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

erlend-aasland commented Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Victor!

erlend-aasland merged commit ee821dc into python:main Nov 15, 2022
erlend-aasland deleted the testcapi/extract-time-stuff branch November 15, 2022 07:18
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Nov 16, 2022
Merge branch 'main' into fix-issue21914 …
abd206e
* main: (8272 commits) Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522) pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461) pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500) pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496) Post 3.12.0a2 pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499) pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494) pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483) pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385) pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488) pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373) pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346) pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487) pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464) pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462) pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479) pythongh-99300: Use Py_NewRef() in Doc/ directory (python#99480) pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473) pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469) pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371) ...
encukou mentioned this pull request Nov 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.