← 返回首页
GH-94597: add deprecation warnings for subclassing `AbstractChildWatcher` by kumaraditya303 · Pull Request #99386 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

GH-94597: add deprecation warnings for subclassing AbstractChildWatcher#99386

Merged
gvanrossum merged 3 commits into
python:mainfrom
kumaraditya303:async-deprecate
Nov 12, 2022
Merged

GH-94597: add deprecation warnings for subclassing AbstractChildWatcher#99386
gvanrossum merged 3 commits into
python:mainfrom
kumaraditya303:async-deprecate

Conversation

kumaraditya303 commented Nov 11, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Nov 11, 2022
Closed

kumaraditya303 commented Nov 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This isn't really needed as deprecation warning will be emitted anyway when configuring the child watcher via set_child_watcher but still adding for anyone who is subclassing this but not configuring the child watcher for whatever reason.

kumaraditya303 mentioned this pull request Nov 11, 2022
Closed
gvanrossum approved these changes Nov 11, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

(Do double check the appearance of the deprecation note.)

Comment thread Doc/library/asyncio-policy.rst Show resolved Hide resolved
gvanrossum merged commit aa87432 into python:main Nov 12, 2022
kumaraditya303 deleted the async-deprecate branch November 12, 2022 07:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.