← 返回首页
gh-93649: Split getargs testing from _testcapimodule.c by erlend-aasland · Pull Request #99346 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-93649: Split getargs testing from _testcapimodule.c#99346

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:testcapi/extract-arg-stuff
Nov 14, 2022
Merged

gh-93649: Split getargs testing from _testcapimodule.c#99346
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:testcapi/extract-arg-stuff

Conversation

erlend-aasland commented Nov 10, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland requested a review from a team as a code owner November 10, 2022 20:55
bedevere-bot mentioned this pull request Nov 10, 2022
Open
Modernise a little bit …
5dfdd5c
- a couple of PEP 7 nits - use intermingled decls a few places - Use Py_NewRef() API to save a few lines

erlend-aasland commented Nov 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

There is some fishy error handling in some of the test methods. Let's handle those in a separate issue/PR. An example is test_k_code(), where tuple leak in multiple branches.

encukou commented Nov 14, 2022

Copy link
Copy Markdown
Member

Leaks in failing tests? The only situation I see where that's is a problem is when tests are used as API usage examples. So, it's good to fix those, but not too important for older tests.

Undefining PyArg_ParseTupleAndKeywords and defining again it is also a bit fishy – IMO it would better to havs the non-Size_T definition in the public header file, albeit shadowed by a macro, so only #undef would suffice. But that's an unrelated issue.

erlend-aasland commented Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

Leaks in failing tests?

Yes, only in error handling paths, and it's not a problem in practice.

Undefining PyArg_ParseTupleAndKeywords and defining again it is also a bit fishy – IMO it would better to havs the non-Size_T definition in the public header file, albeit shadowed by a macro, so only #undef would suffice. But that's an unrelated issue.

+1

erlend-aasland merged commit 3d94319 into python:main Nov 14, 2022
erlend-aasland deleted the testcapi/extract-arg-stuff branch November 14, 2022 21:23
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Nov 16, 2022
Merge branch 'main' into fix-issue21914 …
abd206e
* main: (8272 commits) Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522) pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461) pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500) pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496) Post 3.12.0a2 pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499) pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494) pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483) pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385) pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488) pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373) pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346) pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487) pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464) pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462) pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479) pythongh-99300: Use Py_NewRef() in Doc/ directory (python#99480) pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473) pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469) pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.