← 返回首页
gh-99289: Add COMPILEALL_OPTS to Makefile by vstinner · Pull Request #99291 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-99289: Add COMPILEALL_OPTS to Makefile#99291

Merged
vstinner merged 3 commits into
python:mainfrom
vstinner:compileall_opts
Nov 14, 2022
Merged

gh-99289: Add COMPILEALL_OPTS to Makefile#99291
vstinner merged 3 commits into
python:mainfrom
vstinner:compileall_opts

Conversation

vstinner commented Nov 9, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Add COMPILEALL_OPTS variable in Makefile to override compileall options (default: -j0) in "make install". Merge also the 3 compileall commands into a single command building PYC files for the 3 optimization levels (0, 1, 2).

gh-99289: Add COMPILEALL_OPTS to Makefile …
9313d24
Add COMPILEALL_OPTS variable in Makefile to override compileall options (default: -j0) in "make install". Merge also the 3 compileall commands into a single command building PYC files for the 3 optimization levels (0, 1, 2).
bedevere-bot mentioned this pull request Nov 9, 2022
Closed

vstinner commented Nov 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Example:

./configure --prefix ~/prefix make make install COMPILEALL_OPTS="--hardlink-dupes -j4"

Output:

(...) PYTHONPATH=/home/vstinner/prefix/lib/python3.12 \ ./python -E -Wi /home/vstinner/prefix/lib/python3.12/compileall.py \ -o 0 -o 1 -o 2 --hardlink-dupes -j4 -d /home/vstinner/prefix/lib/python3.12/site-packages -f \ -x badsyntax /home/vstinner/prefix/lib/python3.12/site-packages (...)

compileall is called with options: -o 0 -o 1 -o 2 --hardlink-dupes -j4:

  • -o 0 -o 1 -o 2 is hardcoded
  • default -j0 was overriden with --hardlink-dupes -j4

vstinner commented Nov 9, 2022

Copy link
Copy Markdown
Member Author

I tested again to double check. Ah, in fact compileall is called two times: once for Lib/, once for site-packages:

(...) PYTHONPATH=/home/vstinner/prefix/lib/python3.12 \ ./python -E -Wi /home/vstinner/prefix/lib/python3.12/compileall.py \ -o 0 -o 1 -o 2 --hardlink-dupes -j4 -d /home/vstinner/prefix/lib/python3.12 -f \ -x 'bad_coding|badsyntax|site-packages|test/test_lib2to3/data' \ /home/vstinner/prefix/lib/python3.12 Listing '/home/vstinner/prefix/lib/python3.12'... (...) PYTHONPATH=/home/vstinner/prefix/lib/python3.12 \ ./python -E -Wi /home/vstinner/prefix/lib/python3.12/compileall.py \ -o 0 -o 1 -o 2 --hardlink-dupes -j4 -d /home/vstinner/prefix/lib/python3.12/site-packages -f \ -x badsyntax /home/vstinner/prefix/lib/python3.12/site-packages Listing '/home/vstinner/prefix/lib/python3.12/site-packages'... (...)

vstinner commented Nov 9, 2022

Copy link
Copy Markdown
Member Author

cc @hroncok

hroncok commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

This is an improvement, thanks! OTOH we would probably also like an opinion to disable this entirely and do it ourselves.

vstinner merged commit 9a7e9f9 into python:main Nov 14, 2022

vstinner commented Nov 14, 2022

Copy link
Copy Markdown
Member Author

Merged, thanks for the review!

vstinner deleted the compileall_opts branch November 14, 2022 12:43

vstinner commented Nov 14, 2022

Copy link
Copy Markdown
Member Author

OTOH we would probably also like an opinion to disable this entirely and do it ourselves.

That can be a separated option.

IMO this change alone is already an enhancement ;-)

ngoldbaum mentioned this pull request Mar 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.