← 返回首页
[3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222) by miss-islington · Pull Request #99231 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222)#99231

Merged
ambv merged 1 commit into
python:3.8from
miss-islington:backport-a6f6c3a-3.8
Nov 10, 2022
Merged

[3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222)#99231
ambv merged 1 commit into
python:3.8from
miss-islington:backport-a6f6c3a-3.8

Conversation

Copy link
Copy Markdown
Contributor

miss-islington commented Nov 8, 2022 •
edited by bedevere-bot
Loading

There was an unnecessary quadratic loop in idna decoding. This restores
the behavior to linear.

(cherry picked from commit d315722)

(cherry picked from commit a6f6c3a)

Co-authored-by: Miss Islington (bot) 31488909+miss-islington@users.noreply.github.com
Co-authored-by: Gregory P. Smith greg@krypto.org

[3.11] pythongh-98433: Fix quadratic time idna decoding. (pythonGH-99092 …
064ec20
) (pythonGH-99222) There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear. (cherry picked from commit d315722) (cherry picked from commit a6f6c3a) Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
bedevere-bot mentioned this pull request Nov 8, 2022
Closed
bedevere-bot mentioned this pull request Nov 8, 2022
Merged
bedevere-bot added type-bug An unexpected behavior, bug, or error type-security A security issue labels Nov 8, 2022
gpshead changed the title [3.8] [3.11] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222) [3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222) Nov 8, 2022
Copy link
Copy Markdown
Contributor Author

miss-islington commented Nov 8, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

vstinner approved these changes Nov 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, good bot.

Copy link
Copy Markdown
Member

vstinner commented Nov 9, 2022

@ambv: Would you mind to merge this security fix? It's already in other branches, including 3.7 ;-)

ambv merged commit 82ca283 into python:3.8 Nov 10, 2022
miss-islington deleted the backport-a6f6c3a-3.8 branch November 10, 2022 15:56
Copy link
Copy Markdown
Contributor

ngie-eign commented Nov 15, 2022 •
edited
Loading

@ambv : is there a plan for when the next 3.8 release might be cut? I noticed that this item wasn't in .15; Blackduck is already citing this as an issue, so the need for resolving this in cpython and trickling the fix down will need to come sooner rather than later.

Copy link
Copy Markdown
Member

gpshead commented Nov 15, 2022

Release manager conversations recently suggest they'll be coordinating releases for the week of December 5th.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

vstinner vstinner approved these changes

Assignees

ambv

Labels

release-blocker type-bug An unexpected behavior, bug, or error type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.