← 返回首页
gh-83004: Clean up refleaks in _decimal initialisation by hauntsaninja · Pull Request #99043 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-83004: Clean up refleaks in _decimal initialisation#99043

Closed
hauntsaninja wants to merge 5 commits into
python:mainfrom
hauntsaninja:gh-83004-decimal
Closed

gh-83004: Clean up refleaks in _decimal initialisation#99043
hauntsaninja wants to merge 5 commits into
python:mainfrom
hauntsaninja:gh-83004-decimal

Conversation

hauntsaninja commented Nov 3, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Nov 3, 2022
Closed
hauntsaninja marked this pull request as draft November 3, 2022 06:44
hauntsaninja commented Nov 3, 2022
View reviewed changes
Comment thread Modules/_decimal/_decimal.c
extended_context_template));


/* Init mpd_ssize_t constants */

hauntsaninja Nov 3, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Can't add a comment there because Github, but CHECK_INT(PyModule_AddObject(m, ssize_cm->name, obj)); for obj on L6038 does not leak obj on failure because its reference count is 1 going into PyModule_AddObject and we Py_CLEAR it on goto error inside CHECK_INT.

erlend-aasland Nov 22, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Could you update the PR to add a comment about that?

JelleZijlstra Dec 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Ping on this; there's also a merge conflict.

hauntsaninja marked this pull request as ready for review November 3, 2022 07:18
rhettinger removed their request for review November 4, 2022 01:27

erlend-aasland commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

Superseded by Serhiy's #106858.

hauntsaninja deleted the gh-83004-decimal branch February 9, 2024 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
erlend-aasland erlend-aasland left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.