← 返回首页
gh-83004: Clean up refleak in _zoneinfo initialisation by hauntsaninja · Pull Request #98842 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-83004: Clean up refleak in _zoneinfo initialisation#98842

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
hauntsaninja:gh-83004-zoneinfo
Nov 6, 2022
Merged

gh-83004: Clean up refleak in _zoneinfo initialisation#98842
JelleZijlstra merged 4 commits into
python:mainfrom
hauntsaninja:gh-83004-zoneinfo

Conversation

hauntsaninja commented Oct 29, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

JelleZijlstra commented Nov 2, 2022

Copy link
Copy Markdown
Member

Code looks good, but I think we need a NEWS entry as this fixes a (very unlikely) user-facing issue.

bedevere-bot mentioned this pull request Nov 2, 2022
Closed

hauntsaninja commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

Added the NEWS entry. If you want to review other changes like this, there's #98840 and #98841

I also went through CPython and about 20 other modules are affected. Should I continue to do single module PRs or can I batch them?

JelleZijlstra commented Nov 2, 2022

Copy link
Copy Markdown
Member

Thanks! I think batching them is fine since the change is simple.

JelleZijlstra reviewed Nov 3, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-11-02-05-54-02.gh-issue-83004.0v8iyw.rst Outdated Show resolved Hide resolved
JelleZijlstra self-assigned this Nov 3, 2022
JelleZijlstra merged commit 31f2f65 into python:main Nov 6, 2022

miss-islington commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
pythongh-83004: Clean up refleak in _zoneinfo initialisation (pythonG… …
aadf057
…H-98842) (cherry picked from commit 31f2f65) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

bedevere-bot commented Nov 6, 2022

Copy link
Copy Markdown

GH-99163 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 6, 2022

bedevere-bot commented Nov 6, 2022

Copy link
Copy Markdown

GH-99164 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
pythongh-83004: Clean up refleak in _zoneinfo initialisation (pythonG… …
7cf8db3
…H-98842) (cherry picked from commit 31f2f65) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 6, 2022
gh-83004: Clean up refleak in _zoneinfo initialisation (GH-98842) …
4b1e45e
(cherry picked from commit 31f2f65) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 6, 2022
gh-83004: Clean up refleak in _zoneinfo initialisation (GH-98842) …
70006d6
(cherry picked from commit 31f2f65) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja deleted the gh-83004-zoneinfo branch November 21, 2022 06:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
pganssle Awaiting requested review from pganssle pganssle is a code owner

Assignees

JelleZijlstra

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.