← 返回首页
gh-98636: Fix detecting gdbm_compat for _dbm module by mgorny · Pull Request #98643 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-98636: Fix detecting gdbm_compat for _dbm module#98643

Merged
erlend-aasland merged 1 commit into
python:mainfrom
mgorny:gdbm_compat-98636
Jan 11, 2023
Merged

gh-98636: Fix detecting gdbm_compat for _dbm module#98643
erlend-aasland merged 1 commit into
python:mainfrom
mgorny:gdbm_compat-98636

Conversation

Copy link
Copy Markdown
Contributor

mgorny commented Oct 25, 2022 •
edited
Loading

Fix the gdbm_compat library detection logic to actually check for
-lgdbm_compat independently of the ndbm detection. This fixes the build
failure with --with-dbmliborder=gdbm, and implicit fallback to ndbm
with the default value.

mgorny force-pushed the gdbm_compat-98636 branch from 896c212 to 894ada5 Compare October 25, 2022 10:28
mgorny force-pushed the gdbm_compat-98636 branch from 894ada5 to 72a9700 Compare October 25, 2022 12:03
Copy link
Copy Markdown
Contributor Author

mgorny commented Nov 4, 2022

Ping.

Copy link
Copy Markdown
Contributor Author

mgorny commented Dec 7, 2022

Another ping. It would be really nice to have this fixed.

bedevere-bot mentioned this pull request Dec 18, 2022
Closed
erlend-aasland reviewed Dec 28, 2022
View reviewed changes
Comment thread configure.ac Outdated Show resolved Hide resolved
pythongh-98636: Fix detecting gdbm_compat for _dbm module …
15510e8
Fix the gdbm_compat library detection logic to actually check for -lgdbm_compat independently of the ndbm detection. This fixes the build failure with `--with-dbmliborder=gdbm`, and implicit fallback to ndbm with the default value.
Copy link
Copy Markdown
Contributor Author

mgorny commented Dec 31, 2022

@erlend-aasland, updated as requested.

Copy link
Copy Markdown
Contributor

erlend-aasland commented Jan 11, 2023

Does this need a backport?

Copy link
Copy Markdown
Contributor Author

mgorny commented Jan 11, 2023

Does this need a backport?

Unless I'm mistaken, no. The issue was introduced in ec5e253, and FWICS this in 3.12 only.

thesamesam mentioned this pull request Jan 11, 2023
Merged
erlend-aasland merged commit 02a72f0 into python:main Jan 11, 2023
Copy link
Copy Markdown
Contributor

erlend-aasland commented Jan 11, 2023

Thanks, and sorry for the delay!

If you want to pursue the AC refactorings discussed, please open an issue/PR.

Copy link
Copy Markdown
Contributor Author

mgorny commented Jan 12, 2023

Thank you! I'm happy enough having the immediate problem fixed.

mgorny deleted the gdbm_compat-98636 branch January 12, 2023 06:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes

tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.