← 返回首页
[3.11] gh-98548: Fix `-ne` shell operator spelling by sterliakov · Pull Request #98556 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.11] gh-98548: Fix -ne shell operator spelling#98556

Merged
ambv merged 2 commits into
python:3.11from
sterliakov:gh-98548-3.11
Oct 28, 2022
Merged

[3.11] gh-98548: Fix -ne shell operator spelling#98556
ambv merged 2 commits into
python:3.11from
sterliakov:gh-98548-3.11

Conversation

sterliakov commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

gh-98548: Workflow not equal operator spelling

This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.

This bug is present on 3.10 and 3.11 branches only.

This follows #98555 for another affected branch.

bedevere-bot commented Oct 22, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

hauntsaninja reviewed Oct 23, 2022
View reviewed changes

hauntsaninja left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks for spotting this!

Here is an example workflow run affected: https://github.com/python/cpython/actions/runs/3293756628/jobs/5430563962
That said, I'm not sure this is enough of a fix, because I think Github Actions runs with bash -e. So I think we'd never get to this anyway? One option would be to use || (echo ... ; exit 1) or something

hauntsaninja mentioned this pull request Oct 23, 2022
Merged

sterliakov commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

Since the command expected to fail is short enough, maybe just

if ! make check-abidump; then echo ... fi

is sufficient? The if and until conditions are not considered failing for -e. Yes, gihub actions use set -e (or bash -e, not sure about this) to fail on first failing step.

sterliakov requested review from hauntsaninja and removed request for ezio-melotti October 24, 2022 10:09
hauntsaninja approved these changes Oct 25, 2022
View reviewed changes

hauntsaninja left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks, this looks good to me. Want to update the 3.10 backport #98555 as well? :-) cc @JelleZijlstra

JelleZijlstra self-assigned this Oct 25, 2022

sterliakov commented Oct 25, 2022

Copy link
Copy Markdown
Contributor Author

Updated #98555 too.

ambv merged commit 194588d into python:3.11 Oct 28, 2022
encukou pushed a commit to encukou/cpython that referenced this pull request May 23, 2023
[3.12] Add CI step to check changes in the exported ABI (python#92442) …
1aeeebd
Backport the workflow change and fix-ups: - pythonGH-92442 (e89c01e) - pythonGH-94129 (0dadb22) - pythonGH-98556 (194588d) Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com>
encukou mentioned this pull request May 23, 2023
Merged
Yhg1s pushed a commit that referenced this pull request May 23, 2023
[3.12] gh-87891: Add ABI check to CI (#104793) …
b44beac
Backport the workflow change and fix-ups: - GH-92442 (e89c01e) - GH-94129 (0dadb22) - GH-98556 (194588d) Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja approved these changes

Assignees

JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.