← 返回首页
[3.9] gh-98517: Fix buffer overflows in _sha3 module (GH-98519) by miss-islington · Pull Request #98526 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.9] gh-98517: Fix buffer overflows in _sha3 module (GH-98519)#98526

Merged
ambv merged 1 commit into
python:3.9from
miss-islington:backport-0e4e058-3.9
Oct 28, 2022
Merged

[3.9] gh-98517: Fix buffer overflows in _sha3 module (GH-98519)#98526
ambv merged 1 commit into
python:3.9from
miss-islington:backport-0e4e058-3.9

Conversation

Copy link
Copy Markdown
Contributor

miss-islington commented Oct 21, 2022 •
edited by bedevere-bot
Loading

This is a port of the applicable part of XKCP's fix 1 for
CVE-2022-37454 and avoids the segmentation fault and the infinite
loop in the test cases published in 2.

Regression test added by: Gregory P. Smith [Google LLC] greg@krypto.org
(cherry picked from commit 0e4e058)

Co-authored-by: Theo Buehler botovq@users.noreply.github.com

[3.10] pythongh-98517: Fix buffer overflows in _sha3 module (pythonGH… …
915bdf4
…-98519) This is a port of the applicable part of XKCP's fix [1] for CVE-2022-37454 and avoids the segmentation fault and the infinite loop in the test cases published in [2]. [1]: XKCP/XKCP@fdc6fef [2]: https://mouha.be/sha-3-buffer-overflow/ Regression test added by: Gregory P. Smith [Google LLC] <greg@krypto.org> (cherry picked from commit 0e4e058) Co-authored-by: Theo Buehler <botovq@users.noreply.github.com>
miss-islington requested a review from tiran as a code owner October 21, 2022 19:26
bedevere-bot mentioned this pull request Oct 21, 2022
Merged
bedevere-bot added type-crash A hard crash of the interpreter, possibly with a core dump type-security A security issue labels Oct 21, 2022
gpshead changed the title [3.9] [3.10] gh-98517: Fix buffer overflows in _sha3 module (GH-98519) [3.9] gh-98517: Fix buffer overflows in _sha3 module (GH-98519) Oct 21, 2022
gpshead added the 3.9 (EOL) end of life label Oct 21, 2022
Copy link
Copy Markdown
Contributor Author

miss-islington commented Oct 21, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

ambv merged commit 857efee into python:3.9 Oct 28, 2022
miss-islington deleted the backport-0e4e058-3.9 branch October 28, 2022 10:08
arhadthedev mentioned this pull request Jun 27, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

tiran Awaiting requested review from tiran tiran is a code owner

Assignees

ambv

Labels

3.9 (EOL) end of life release-blocker type-crash A hard crash of the interpreter, possibly with a core dump type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.