← 返回首页
gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values by ethanfurman · Pull Request #98455 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values#98455

Merged
ethanfurman merged 4 commits into
python:mainfrom
ethanfurman:enum-whatsnew
Oct 21, 2022
Merged

gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values#98455
ethanfurman merged 4 commits into
python:mainfrom
ethanfurman:enum-whatsnew

Conversation

ethanfurman commented Oct 19, 2022
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Oct 19, 2022
ethanfurman removed docs Documentation in the Doc dir awaiting core review labels Oct 19, 2022

Copy link
Copy Markdown
Member Author

@CAM-Gerlach ReprEnum, global_enum, and show_flag_values added to documentation. Please fix any formatting issues, etc., and feel free to merge.

CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes docs Documentation in the Doc dir labels Oct 19, 2022

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks so much @ethanfurman ! I've added some suggestions for Sphinx syntax and formatting, and a couple wording clarifications on points that confused me initially as a non-enum-expert. I can't do so myself as I'm not a core dev, but you can review and apply them with just a couple clicks under Files, click Add to Batch then Commit (or revise them with your own suggestions and apply those), and then feel free to merge, assuming I didn't make any syntax typos (there isn't a direct way for me to test them locally without committing them). Thanks!

Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
CAM-Gerlach mentioned this pull request Oct 19, 2022
33 tasks

CAM-Gerlach left a comment
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Fixes for my error-causing typo, a change not applied before and one other point of confusion I noticed with my previous revision.

Also, FYI, you can avoid having to tediously apply the changes manually by just adding the suggestions to the batch under the Files tab, and then Commit-ing them in one go—I'd hate for you to waste your valuable core dev time tediously implementing my minor fixes by hand. It will also auto-resolve the respective review suggestions, getting them out of the way.

Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/enum.rst Outdated Show resolved Hide resolved
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

Copy link
Copy Markdown
Member Author

@CAM-Gerlach Cool, I didn't know about the batch committing of suggestions.

ethanfurman self-assigned this Oct 21, 2022
ethanfurman merged commit 3e95ffc into python:main Oct 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2022
…values (pythonGH-98455) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> (cherry picked from commit 3e95ffc) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

Copy link
Copy Markdown

GH-98530 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 21, 2022
miss-islington added a commit that referenced this pull request Oct 21, 2022
…GH-98455) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> (cherry picked from commit 3e95ffc) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman deleted the enum-whatsnew branch November 23, 2022 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.