← 返回首页
gh-97527: IDLE - fix buggy macosx patch by terryjreedy · Pull Request #98313 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-97527: IDLE - fix buggy macosx patch#98313

Merged
terryjreedy merged 2 commits into
python:mainfrom
terryjreedy:macgui
Oct 16, 2022
Merged

gh-97527: IDLE - fix buggy macosx patch#98313
terryjreedy merged 2 commits into
python:mainfrom
terryjreedy:macgui

Conversation

terryjreedy commented Oct 16, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

#97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac.

pythongh-97527: IDLE - fix buggy macosx patch …
9ee8f5c
python#97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac.
terryjreedy added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 16, 2022
terryjreedy requested a review from pablogsal October 16, 2022 01:43
terryjreedy self-assigned this Oct 16, 2022
terryjreedy mentioned this pull request Oct 16, 2022
Closed
terryjreedy removed the request for review from pablogsal October 16, 2022 02:29
terryjreedy merged commit 35fa5d5 into python:main Oct 16, 2022

miss-islington commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2022
pythongh-97527: IDLE - fix buggy macosx patch (pythonGH-98313) …
d4a2d06
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac. (cherry picked from commit 35fa5d5) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot commented Oct 16, 2022

Copy link
Copy Markdown

GH-98329 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 16, 2022

bedevere-bot commented Oct 16, 2022

Copy link
Copy Markdown

GH-98330 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 16, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2022
pythongh-97527: IDLE - fix buggy macosx patch (pythonGH-98313) …
36a6279
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac. (cherry picked from commit 35fa5d5) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy deleted the macgui branch October 16, 2022 14:32

terryjreedy commented Oct 16, 2022

Copy link
Copy Markdown
Member Author

The code for test.support.resource raises ResourceDenied(reason) on failure.
I manually tested that with this patch, IDLE starts with test renamed to test2, so that any import of test fails.
No unittest invoked from test/ can test what happens when test/ is not present.

arhadthedev commented Oct 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

and Microsoft Python 3.10.2288.0 when test/* is not installed

Links for historical purposes:

terryjreedy mentioned this pull request Oct 16, 2022
Closed
terryjreedy added the needs backport to 3.11 only security fixes label Oct 16, 2022

miss-islington commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2022
pythongh-97527: IDLE - fix buggy macosx patch (pythonGH-98313) …
50ef214
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac. (cherry picked from commit 35fa5d5) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Oct 16, 2022
gh-97527: IDLE - fix buggy macosx patch (GH-98313) …
928b5f1
GH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac. (cherry picked from commit 35fa5d5) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

terryjreedy commented Oct 16, 2022

Copy link
Copy Markdown
Member Author

3.11 backport originally failed due to randon failure in a non-idle test. Re-adding backport label triggered retesting in original backport PR.

miss-islington added a commit that referenced this pull request Oct 16, 2022
gh-97527: IDLE - fix buggy macosx patch (GH-98313) …
21fbf16
GH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac. (cherry picked from commit 35fa5d5) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
carljm added a commit to carljm/cpython that referenced this pull request Oct 17, 2022
Merge branch 'main' into typewatch …
cdbe93b
* main: (31 commits) pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345) pythongh-95914: Add What's New item describing PEP 670 changes (python#98315) Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358) pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316) pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333) pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001) pythongh-97669: Create Tools/build/ directory (python#97963) pythongh-95534: Improve gzip reading speed by 10% (python#97664) pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344) pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336) pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929) pythongh-85525: Remove extra row in doc (python#98337) pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457) pythongh-97527: IDLE - fix buggy macosx patch (python#98313) pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319) pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158) pythonGH-94597: Deprecate child watcher getters and setters (python#98215) pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255) Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294) [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290) ...
ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

terryjreedy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.