← 返回首页
gh-94808: Cover `PyEval_GetFuncDesc` function by sobolevn · Pull Request #98300 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-94808: Cover PyEval_GetFuncDesc function#98300

Merged
iritkatriel merged 3 commits into
python:mainfrom
sobolevn:cover-pyeval-get-function-desc
Nov 5, 2022
Merged

gh-94808: Cover PyEval_GetFuncDesc function#98300
iritkatriel merged 3 commits into
python:mainfrom
sobolevn:cover-pyeval-get-function-desc

Conversation

sobolevn commented Oct 15, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This function is very stange. I don't understand:

  • Why it is needed
  • Why it is " object" and not "object"

Related #81826

CC @encukou
Can we deprecate it?

JelleZijlstra commented Oct 16, 2022

Copy link
Copy Markdown
Member

Looks like it's part of the stable ABI, so for the moment we can't get rid of it. It was used in 2.7:

cpython/Python/ceval.c

Line 4499 in 8d21aa2

PyEval_GetFuncDesc(func),

sobolevn commented Oct 16, 2022

Copy link
Copy Markdown
Member Author

so for the moment we can't get rid of it.

But, we can at least deprecate it :)

encukou commented Oct 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

It's intended to be used with PyEval_GetFuncName, so it appends () in foo() but [space]object in SomeType object. As external API, it's definitely weird.
See #81826 for deprecating them both.

mdboom mentioned this pull request Oct 19, 2022
Open
sobolevn requested a review from iritkatriel November 5, 2022 12:22
iritkatriel self-assigned this Nov 5, 2022
iritkatriel added the needs backport to 3.10 only security fixes label Nov 5, 2022
iritkatriel merged commit b5f7111 into python:main Nov 5, 2022

miss-islington commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @iritkatriel, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b5f711185bd11819566068ddf2a74a1402340e2d 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2022
pythongh-94808: add tests covering PyEval_GetFuncDesc function (pyt… …
40490c1
…honGH-98300) (cherry picked from commit b5f7111) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Nov 5, 2022

Copy link
Copy Markdown

GH-99126 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 5, 2022
miss-islington added a commit that referenced this pull request Nov 5, 2022
gh-94808: add tests covering PyEval_GetFuncDesc function (GH-98300) …
46a493e
(cherry picked from commit b5f7111) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ZeroIntensity removed the needs backport to 3.10 only security fixes label Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
iritkatriel iritkatriel approved these changes

Assignees

iritkatriel

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Footer

© 2026 GitHub, Inc.