← 返回首页
gh-96512: Move int_max_str_digits setting to PyConfig by gpshead · Pull Request #96944 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-96512: Move int_max_str_digits setting to PyConfig#96944

Merged
gpshead merged 9 commits into
python:mainfrom
gpshead:cleanup/int-dos-use-pyconfig
Oct 3, 2022
Merged

gh-96512: Move int_max_str_digits setting to PyConfig#96944
gpshead merged 9 commits into
python:mainfrom
gpshead:cleanup/int-dos-use-pyconfig

Conversation

gpshead commented Sep 20, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

It had to live as a global outside of PyConfig for stable ABI reasons in the pre-3.12 backports.

This removes the _Py_global_config_int_max_str_digits and gets rid of the equivalent field in the internal struct _is PyInterpreterState as code can just use the existing nested config struct within that.

pythongh-96512: Move int_max_str_digits setting to PyConfig …
cf20758
It had to live as a global outside of PyConfig for stable ABI reasons in the pre-3.12 backports. This removes the `_Py_global_config_int_max_str_digits` and gets rid of the equivalent field in the internal `struct _is PyInterpreterState` as code can just use the existing nested config struct within that.
Add a test_capi test to verify unique configs. …
86c4b6e
Also demonstrates that subinterpreters maintain their own limit as a feature.
gpshead self-assigned this Sep 20, 2022

gpshead commented Sep 20, 2022

Copy link
Copy Markdown
Member Author

This pulls out the important config change from #96568, addressing its comments.

gpshead added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API labels Sep 20, 2022
gpshead commented Sep 20, 2022
View reviewed changes
Comment thread Python/sysmodule.c Outdated Show resolved Hide resolved
gpshead marked this pull request as ready for review September 20, 2022 01:25
vstinner reviewed Sep 21, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Nice, I like this change overall :-) Here is a first review.

Comment thread Python/sysmodule.c Outdated Show resolved Hide resolved
Comment thread Python/initconfig.c Outdated Show resolved Hide resolved
Comment thread Python/initconfig.c Outdated Show resolved Hide resolved
Comment thread Python/sysmodule.c Outdated Show resolved Hide resolved
Comment thread Programs/_testembed.c Show resolved Hide resolved
Comment thread Doc/c-api/init_config.rst Outdated Show resolved Hide resolved
Comment thread Doc/c-api/init_config.rst Show resolved Hide resolved
Comment thread Lib/test/test_capi.py Outdated Show resolved Hide resolved
Comment thread Lib/test/test_capi.py Outdated Show resolved Hide resolved
mdickinson removed their request for review September 25, 2022 09:39

mdickinson commented Sep 25, 2022

Copy link
Copy Markdown
Member

Removing myself from review; Victor's got this. :-)

gpshead commented Oct 1, 2022

Copy link
Copy Markdown
Member Author

I think this is ready, please take another look @vstinner

vstinner approved these changes Oct 3, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

Comment thread Lib/test/test_capi.py Show resolved Hide resolved
gpshead merged commit b0f89cb into python:main Oct 3, 2022
gpshead deleted the cleanup/int-dos-use-pyconfig branch October 3, 2022 20:56
carljm added a commit to carljm/cpython that referenced this pull request Oct 3, 2022
Merge branch 'main' into dictwatch …
e83abac
* main: (2069 commits) pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944) pythongh-94808: Coverage: Check picklablability of calliter (python#95923) pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627) pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765) Fix typos in `bltinmodule.c`. (pythonGH-97766) pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609) pythongh-97681: Remove Tools/demo/ directory (python#97682) Fix typo in unittest docs (python#97742) pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729) pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739) pythongh-95913: Copyedit/improve New Modules What's New section (python#97721) pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741) pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890) pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707) pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738) [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730) pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652) pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976) pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700) pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919) ...
ericsnowcurrently mentioned this pull request Oct 18, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv left review comments
vstinner vstinner approved these changes

Assignees

gpshead

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.