← 返回首页
gh-93963: Remove ResourceReaderDefaultsTests by jaraco · Pull Request #96598 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-93963: Remove ResourceReaderDefaultsTests#96598

Merged
miss-islington merged 1 commit into
python:mainfrom
jaraco:bpo-93963/remove-resource-reader-defaults-tests
Sep 5, 2022
Merged

gh-93963: Remove ResourceReaderDefaultsTests#96598
miss-islington merged 1 commit into
python:mainfrom
jaraco:bpo-93963/remove-resource-reader-defaults-tests

Conversation

jaraco commented Sep 5, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

bpo-93963: Remove ResourceReaderDefaultsTests. If these tests are imp… …
30133e7
…ortant, they should be implemented in importlib_resources.
bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 5, 2022
jaraco added the needs backport to 3.11 only security fixes label Sep 5, 2022
jaraco changed the title bpo-93963: Remove ResourceReaderDefaultsTests gh-93963: Remove ResourceReaderDefaultsTests Sep 5, 2022
jaraco requested a review from iritkatriel September 5, 2022 19:01
jaraco mentioned this pull request Sep 5, 2022
Closed
5 tasks
miss-islington merged commit 52fe7e5 into python:main Sep 5, 2022

miss-islington commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Sorry, @jaraco, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 52fe7e50c9945b7db60190b4b97e1213d05200b2 3.11

miss-islington self-assigned this Sep 5, 2022

bedevere-bot commented Sep 5, 2022

Copy link
Copy Markdown

GH-96602 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 5, 2022
jaraco added a commit to jaraco/cpython that referenced this pull request Sep 5, 2022
[3.11] pythongh-93963: Remove ResourceReaderDefaultsTests (pythonGH-9… …
04644c1
…6598) Automerge-Triggered-By: GH:jaraco. (cherry picked from commit 52fe7e5) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco deleted the bpo-93963/remove-resource-reader-defaults-tests branch September 5, 2022 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes

Assignees

miss-islington

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.