← 返回首页
gh-96143: Add some comments and minor fixes missed in the original PR by pablogsal · Pull Request #96433 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-96143: Add some comments and minor fixes missed in the original PR#96433

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-96143
Aug 30, 2022
Merged

gh-96143: Add some comments and minor fixes missed in the original PR#96433
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-96143

Conversation

pablogsal commented Aug 30, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Automerge-Triggered-By: GH:pablogsal

pablogsal mentioned this pull request Aug 30, 2022
Merged
pablogsal changed the title gh-96132: Add some comments and minor fixes missed in the original PR gh-96143: Add some comments and minor fixes missed in the original PR Aug 30, 2022
kumaraditya303 reviewed Aug 30, 2022
View reviewed changes
Comment thread Doc/using/cmdline.rst Outdated Show resolved Hide resolved
Update Doc/using/cmdline.rst …
fea741d
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
kumaraditya303 reviewed Aug 30, 2022
View reviewed changes
Comment thread Objects/perf_trampoline.c
}
// Some systems may prevent us from creating executable code on the fly.
// TODO: Call icache invalidation intrinsics if available:
// __builtin___clear_cache/__clear_cache (depending if clang/gcc). This is

kumaraditya303 Aug 30, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

The kernel would clear the icache for us. Not sure if this would ever be a problem.

pablogsal Aug 30, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

That's not correct in the general case. You are supposed to call this in aarch64 if you modify the code in some executable segment after it was read at least once. This doesn't apply for us but is not true that in all systems the kernel will clear it for us

pablogsal Aug 30, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

See the discussion in the previous pr

pablogsal merged commit f49dd54 into python:main Aug 30, 2022
pablogsal deleted the gh-96143 branch August 30, 2022 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.