← 返回首页
gh-94808: Improve coverage of _PyBytes_FormatEx by mdboom · Pull Request #95895 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-94808: Improve coverage of _PyBytes_FormatEx#95895

Merged
miss-islington merged 2 commits into
python:mainfrom
mdboom:coverage-bytesobject-PyBytes_FormatEx
Sep 7, 2022
Merged

gh-94808: Improve coverage of _PyBytes_FormatEx#95895
miss-islington merged 2 commits into
python:mainfrom
mdboom:coverage-bytesobject-PyBytes_FormatEx

Conversation

mdboom commented Aug 11, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

There were two specific areas not covered:

  • %(name) syntax
  • %*s syntax

Automerge-Triggered-By: GH:iritkatriel

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 11, 2022
mdboom mentioned this pull request Aug 11, 2022
Open
pythongh-94808: Improve coverage of _PyBytes_FormatEx …
d301fc3
There were two specific areas not covered: - %(name) syntax - %*s syntax
mdboom force-pushed the coverage-bytesobject-PyBytes_FormatEx branch from d3efc12 to d301fc3 Compare August 11, 2022 17:38
iritkatriel approved these changes Sep 7, 2022
View reviewed changes

iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

miss-islington commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

miss-islington merged commit dde15f5 into python:main Sep 7, 2022

miss-islington commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2022
pythongh-94808: Improve coverage of _PyBytes_FormatEx (pythonGH-95895) …
c1964ac
There were two specific areas not covered: - %(name) syntax - %*s syntax Automerge-Triggered-By: GH:iritkatriel (cherry picked from commit dde15f5) Co-authored-by: Michael Droettboom <mdboom@gmail.com>
bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 7, 2022

bedevere-bot commented Sep 7, 2022

Copy link
Copy Markdown

GH-96647 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Sep 7, 2022
gh-94808: Improve coverage of _PyBytes_FormatEx (GH-95895) …
295f510
There were two specific areas not covered: - %(name) syntax - %*s syntax Automerge-Triggered-By: GH:iritkatriel (cherry picked from commit dde15f5) Co-authored-by: Michael Droettboom <mdboom@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.