← 返回首页
[3.11] GH-93516: Drop broken assert, fixes GH-93769 by tiran · Pull Request #94411 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.11] GH-93516: Drop broken assert, fixes GH-93769#94411

Merged
markshannon merged 1 commit into
python:3.11from
tiran:gh-93516-fix
Jun 29, 2022
Merged

[3.11] GH-93516: Drop broken assert, fixes GH-93769#94411
markshannon merged 1 commit into
python:3.11from
tiran:gh-93516-fix

Conversation

tiran commented Jun 29, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The assert is broken on big endian platforms and not present in the
main branch. Drop it.

Correct version would be _PyOpcode_Deopt[_Py_OPCODE(...)] instead of
_PyOpcode_Deopt[...].

[3.11] pythonGH-93516: Drop broken assert, fixes pythonGH-93769 …
8fd8bc4
The ``assert`` is broken on big endian platforms and not present in the main branch. Drop it. Correct version would be ``_PyOpcode_Deopt[_Py_OPCODE(...)]`` instead of ``_PyOpcode_Deopt[...]``.
tiran requested a review from markshannon as a code owner June 29, 2022 10:46
tiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jun 29, 2022

bedevere-bot commented Jun 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 8fd8bc4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
tiran mentioned this pull request Jun 29, 2022
Closed

markshannon commented Jun 29, 2022

Copy link
Copy Markdown
Member

Thanks

markshannon merged commit 9140c41 into python:3.11 Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.