← 返回首页
gh-90016: Deprecate default sqlite3 adapters and converters by erlend-aasland · Pull Request #94276 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-90016: Deprecate default sqlite3 adapters and converters#94276

Merged
erlend-aasland merged 9 commits into
python:mainfrom
erlend-aasland:sqlite-deprecate-adapters
Jul 20, 2022
Merged

gh-90016: Deprecate default sqlite3 adapters and converters#94276
erlend-aasland merged 9 commits into
python:mainfrom
erlend-aasland:sqlite-deprecate-adapters

Conversation

erlend-aasland commented Jun 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes gh-90016

erlend-aasland mentioned this pull request Jun 25, 2022
Closed

erlend-aasland commented Jun 25, 2022

Copy link
Copy Markdown
Contributor Author

cc. @iafisher: would you mind reviewing this?

iafisher reviewed Jun 25, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Comment thread Lib/sqlite3/dbapi2.py Show resolved Hide resolved
erlend-aasland commented Jun 26, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Erlend Egeberg Aasland and others added 2 commits June 27, 2022 18:00
CAM-Gerlach reviewed Jun 29, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks @erlend-aasland , and sorry for the delay! Just a handful of textual and reST/Sphinx fixes/suggestions.

Comment thread Doc/library/sqlite3.rst Show resolved Hide resolved
Comment thread Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Comment thread Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst Outdated Show resolved Hide resolved
Comment thread Lib/sqlite3/dbapi2.py Outdated Show resolved Hide resolved
Comment thread Doc/library/sqlite3.rst Show resolved Hide resolved
Comment thread Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/sqlite3.rst Show resolved Hide resolved
Comment thread Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
AlexWaygood reviewed Jul 1, 2022
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Again, +1 to most of Cam's thoughts

erlend-aasland commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

Reviews addressed in d3dd3b4

CAM-Gerlach approved these changes Jul 2, 2022
View reviewed changes

CAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, thanks @erlend-aasland ! Just two minor fixes, both my mistake.

Comment thread Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst Outdated Show resolved Hide resolved
Comment thread Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Erlend Egeberg Aasland and others added 2 commits July 2, 2022 08:34
Update Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB… …
df4dc31
…409s.rst Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Update Doc/whatsnew/3.12.rst …
ffdf631
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

erlend-aasland commented Jul 3, 2022

Copy link
Copy Markdown
Contributor Author

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

@serhiy-storchaka and @malemburg, would you two mind reviewing this?

felixxm commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

Yes, it works for us 👍 Thanks for letting me know 🎁 . I prepared PR with missing adapters/converters for Django, see django/django#15815.

felixxm approved these changes Jul 4, 2022
View reviewed changes

felixxm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

@erlend-aasland Thanks 👍

Comment thread Lib/sqlite3/dbapi2.py Outdated Show resolved Hide resolved

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

I'll resolve the conflicts and land this PR later tonight.

erlend-aasland merged commit 6dadf6c into python:main Jul 20, 2022
erlend-aasland deleted the sqlite-deprecate-adapters branch July 20, 2022 19:38
hugovk mentioned this pull request Nov 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood left review comments
CAM-Gerlach CAM-Gerlach approved these changes
berkerpeksag Awaiting requested review from berkerpeksag
serhiy-storchaka Awaiting requested review from serhiy-storchaka
malemburg Awaiting requested review from malemburg
+2 more reviewers
iafisher iafisher left review comments
felixxm felixxm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate default converters in sqlite3

6 participants

Footer

© 2026 GitHub, Inc.