← 返回首页
[3.10] gh-61162: Clarify sqlite3 connection context manager docs (GH-93890) by miss-islington · Pull Request #94012 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.10] gh-61162: Clarify sqlite3 connection context manager docs (GH-93890)#94012

Merged
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-8e08978-3.10
Jun 19, 2022
Merged

[3.10] gh-61162: Clarify sqlite3 connection context manager docs (GH-93890)#94012
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-8e08978-3.10

Conversation

miss-islington commented Jun 19, 2022

Copy link
Copy Markdown
Contributor

Explicitly note that transactions are only closed if there is an open
transation at __exit__, and that transactions are not implicitly
opened during __enter__.

Co-authored-by: CAM Gerlach CAM.Gerlach@Gerlach.CAM
Co-authored-by: Stanley 46876382+slateny@users.noreply.github.com

Automerge-Triggered-By: GH:erlend-aasland
(cherry picked from commit 8e08978)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@protonmail.com

pythongh-61162: Clarify sqlite3 connection context manager docs (pyth… …
6c22da6
…onGH-93890) Explicitly note that transactions are only closed if there is an open transation at `__exit__`, and that transactions are not implicitly opened during `__enter__`. Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com> Automerge-Triggered-By: GH:erlend-aasland (cherry picked from commit 8e08978) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

miss-islington commented Jun 19, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jun 19, 2022
bedevere-bot mentioned this pull request Jun 19, 2022
Merged
erlend-aasland mentioned this pull request Jun 19, 2022
Closed

miss-islington commented Jun 19, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

miss-islington merged commit cdf3689 into python:3.10 Jun 19, 2022
miss-islington deleted the backport-8e08978-3.10 branch June 19, 2022 20:26

miss-islington commented Jun 19, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.