← 返回首页
gh-93963: Officially deprecate abcs and warn about their usage. by jaraco · Pull Request #93965 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-93963: Officially deprecate abcs and warn about their usage.#93965

Merged
miss-islington merged 5 commits into
mainfrom
gh-93963/deprecate-importlib-resources-abcs
Jul 3, 2022
Merged

gh-93963: Officially deprecate abcs and warn about their usage.#93965
miss-islington merged 5 commits into
mainfrom
gh-93963/deprecate-importlib-resources-abcs

Conversation

jaraco commented Jun 17, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

jaraco added the needs backport to 3.11 only security fixes label Jun 17, 2022
jaraco force-pushed the gh-93963/deprecate-importlib-resources-abcs branch from 2064d07 to 7890672 Compare June 17, 2022 20:14
jaraco force-pushed the gh-93963/deprecate-importlib-resources-abcs branch from 7890672 to 5e7fb9c Compare June 17, 2022 20:23
graingert reviewed Jun 17, 2022
View reviewed changes
Comment thread Lib/importlib/abc.py Outdated Show resolved Hide resolved
Adopt better wording …
63c3c76
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
hugovk requested changes Jun 17, 2022
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Please could you note the deprecations in https://docs.python.org/3.12/library/importlib.html with deprecated-removed?

and list under https://docs.python.org/3.12/whatsnew/3.12.html#pending-removal-in-python-3-13 ?

Comment thread Lib/importlib/abc.py Outdated Show resolved Hide resolved

hugovk commented Jun 17, 2022

Copy link
Copy Markdown
Member

According to PEP 387, if these are being deprecated in 3.12, is 3.14 the earliest they can be removed?

warsaw requested changes Jun 17, 2022
View reviewed changes

warsaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Added some questions.

Comment thread Lib/importlib/abc.py Show resolved Hide resolved
Comment thread Lib/importlib/abc.py Outdated Show resolved Hide resolved
Comment thread Lib/importlib/abc.py Show resolved Hide resolved

bedevere-bot commented Jun 17, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

encukou commented Jun 27, 2022

Copy link
Copy Markdown
Member

Honestly, I don't think all this is necessary. What would be the harm if they stay importable from both places?

warsaw commented Jun 27, 2022

Copy link
Copy Markdown
Member

Honestly, I don't think all this is necessary. What would be the harm if they stay importable from both places?

From a backward compatibility question, none. But we should be crisp in the documentation about where the proper place to import them from is, and add deprecations for the old places.

jaraco mentioned this pull request Jul 2, 2022
Closed

jaraco commented Jul 2, 2022

Copy link
Copy Markdown
Member Author

According to PEP 387, if these are being deprecated in 3.12, is 3.14 the earliest they can be removed?

Yes, although I contend it would be preferable to deprecate these in 3.11 for removal in 3.13, given that is the prior intention.

hugovk commented Jul 3, 2022

Copy link
Copy Markdown
Member

Okay! I thought the 3.11 beta period was too late for new deprecations, but let's check with @pablogsal to see if this can be backported to 3.11.

pablogsal commented Jul 3, 2022

Copy link
Copy Markdown
Member

Okay! I thought the 3.11 beta period was too late for new deprecations, but let's check with @pablogsal to see if this can be backported to 3.11.

Indeed, unfortunately is too late to add new deprecations to 3.11, specially given how unstable 3.11 is already. Sadly this needs to be done starting in 3.12 :(

jaraco removed the needs backport to 3.11 only security fixes label Jul 3, 2022
graingert reviewed Jul 3, 2022
View reviewed changes
Comment thread Lib/importlib/abc.py Outdated Show resolved Hide resolved

jaraco commented Jul 3, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

bedevere-bot commented Jul 3, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

bedevere-bot requested a review from warsaw July 3, 2022 14:39
jaraco mentioned this pull request Jul 3, 2022
Closed
5 tasks
jaraco mentioned this pull request Jul 3, 2022
Closed
miss-islington merged commit 71848c9 into main Jul 3, 2022
miss-islington deleted the gh-93963/deprecate-importlib-resources-abcs branch July 3, 2022 19:17
hugovk mentioned this pull request Jul 4, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

graingert graingert left review comments
hugovk hugovk requested changes
warsaw warsaw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Officially deprecate and remove abcs in importlib.abc moved to importlib.resources.

8 participants

Footer

© 2026 GitHub, Inc.