← 返回首页
[3.11] gh-91577: SharedMemory move imports out of methods (GH-91579) by miss-islington · Pull Request #93906 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.11] gh-91577: SharedMemory move imports out of methods (GH-91579)#93906

Merged
miss-islington merged 1 commit into
python:3.11from
miss-islington:backport-9a458be-3.11
Jun 16, 2022
Merged

[3.11] gh-91577: SharedMemory move imports out of methods (GH-91579)#93906
miss-islington merged 1 commit into
python:3.11from
miss-islington:backport-9a458be-3.11

Conversation

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

SharedMemory.unlink() uses the unregister() function from resource_tracker. Previously it was imported in the method, but this can fail if the method is called during interpreter shutdown, for example when unlink is part of a del() method.

Moving the import to the top of the file, means that the unregister() method is available during interpreter shutdown.

The register call in SharedMemory.init() can also use this imported resource_tracker.
(cherry picked from commit 9a458be)

Co-authored-by: samtygier samtygier@yahoo.co.uk

pythongh-91577: SharedMemory move imports out of methods (pythonGH-91579 …
59bbbba
) SharedMemory.unlink() uses the unregister() function from resource_tracker. Previously it was imported in the method, but this can fail if the method is called during interpreter shutdown, for example when unlink is part of a __del__() method. Moving the import to the top of the file, means that the unregister() method is available during interpreter shutdown. The register call in SharedMemory.__init__() can also use this imported resource_tracker. (cherry picked from commit 9a458be) Co-authored-by: samtygier <samtygier@yahoo.co.uk>
miss-islington requested a review from tiran as a code owner June 16, 2022 13:42

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

bedevere-bot mentioned this pull request Jun 16, 2022
Merged

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Jun 16, 2022

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

vstinner approved these changes Jun 16, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, good bot.

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

miss-islington merged commit 0c49a09 into python:3.11 Jun 16, 2022
miss-islington deleted the backport-9a458be-3.11 branch June 16, 2022 14:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
tiran Awaiting requested review from tiran tiran is a code owner

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.