← 返回首页
[3.11] gh-91321: Fix test_cppext for C++03 (GH-93902) by miss-islington · Pull Request #93904 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.11] gh-91321: Fix test_cppext for C++03 (GH-93902)#93904

Merged
vstinner merged 1 commit into
python:3.11from
miss-islington:backport-a38c2a6-3.11
Jun 16, 2022
Merged

[3.11] gh-91321: Fix test_cppext for C++03 (GH-93902)#93904
vstinner merged 1 commit into
python:3.11from
miss-islington:backport-a38c2a6-3.11

Conversation

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

Don't build _testcppext.cpp with -Wzero-as-null-pointer-constant when
testing C++03: only use this compiler flag with C++11.
(cherry picked from commit a38c2a6)

Co-authored-by: Victor Stinner vstinner@python.org

pythongh-91321: Fix test_cppext for C++03 (pythonGH-93902) …
619ae36
Don't build _testcppext.cpp with -Wzero-as-null-pointer-constant when testing C++03: only use this compiler flag with C++11. (cherry picked from commit a38c2a6) Co-authored-by: Victor Stinner <vstinner@python.org>
bedevere-bot mentioned this pull request Jun 16, 2022
Merged

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

vstinner approved these changes Jun 16, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, good bot.

vstinner commented Jun 16, 2022

Copy link
Copy Markdown
Member

Ah, two CI checks failed with a network issue:

Could not connect to ppa.launchpad.net:80 (185.125.190.52), connection timed out

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ❌ .

vstinner merged commit 62f72e4 into python:3.11 Jun 16, 2022
miss-islington deleted the backport-a38c2a6-3.11 branch June 16, 2022 13:17

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.