← 返回首页
[3.9] gh-91810: Fix regression with writing an XML declaration with encoding='unicode' (GH-93426) by miss-islington · Pull Request #93791 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.9] gh-91810: Fix regression with writing an XML declaration with encoding='unicode' (GH-93426)#93791

Merged
ambv merged 1 commit into
python:3.9from
miss-islington:backport-d7db9dc-3.9
Jun 16, 2022
Merged

[3.9] gh-91810: Fix regression with writing an XML declaration with encoding='unicode' (GH-93426)#93791
ambv merged 1 commit into
python:3.9from
miss-islington:backport-d7db9dc-3.9

Conversation

miss-islington commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

Suppress writing an XML declaration in open files in ElementTree.write()
with encoding='unicode' and xml_declaration=None.

If file patch is passed to ElementTree.write() with encoding='unicode',
always open a new file in UTF-8.
(cherry picked from commit d7db9dc)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

pythongh-91810: Fix regression with writing an XML declaration with e… …
73edebc
…ncoding='unicode' (pythonGH-93426) Suppress writing an XML declaration in open files in ElementTree.write() with encoding='unicode' and xml_declaration=None. If file patch is passed to ElementTree.write() with encoding='unicode', always open a new file in UTF-8. (cherry picked from commit d7db9dc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

miss-islington commented Jun 14, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented Jun 14, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

bedevere-bot added the type-bug An unexpected behavior, bug, or error label Jun 14, 2022
bedevere-bot mentioned this pull request Jun 14, 2022
Merged

miss-islington commented Jun 14, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

miss-islington commented Jun 14, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

ambv merged commit 893adbf into python:3.9 Jun 16, 2022
miss-islington deleted the backport-d7db9dc-3.9 branch June 16, 2022 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.