← 返回首页
[3.10] gh-93353: Fix importlib.resources._tempfile() finalizer (GH-93377) by miss-islington · Pull Request #93780 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.10] gh-93353: Fix importlib.resources._tempfile() finalizer (GH-93377)#93780

Merged
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-443ca73-3.10
Jun 13, 2022
Merged

[3.10] gh-93353: Fix importlib.resources._tempfile() finalizer (GH-93377)#93780
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-443ca73-3.10

Conversation

miss-islington commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

Fix the importlib.resources.as_file() context manager to remove the
temporary file if destroyed late during Python finalization: keep a
local reference to the os.remove() function. Patch by Victor Stinner.
(cherry picked from commit 443ca73)

Co-authored-by: Victor Stinner vstinner@python.org

pythongh-93353: Fix importlib.resources._tempfile() finalizer (python… …
3c96288
…GH-93377) Fix the importlib.resources.as_file() context manager to remove the temporary file if destroyed late during Python finalization: keep a local reference to the os.remove() function. Patch by Victor Stinner. (cherry picked from commit 443ca73) Co-authored-by: Victor Stinner <vstinner@python.org>
bedevere-bot mentioned this pull request Jun 13, 2022
Merged

miss-islington commented Jun 13, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

vstinner approved these changes Jun 13, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, good bot.

miss-islington commented Jun 13, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

miss-islington merged commit f9585e2 into python:3.10 Jun 13, 2022
miss-islington deleted the backport-443ca73-3.10 branch June 13, 2022 17:52
dimbleby mentioned this pull request Nov 23, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.