← 返回首页
gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB by pablogsal · Pull Request #93700 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB#93700

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:91731
Jun 13, 2022
Merged

gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB#93700
pablogsal merged 2 commits into
python:mainfrom
pablogsal:91731

Conversation

pablogsal commented Jun 10, 2022

Copy link
Copy Markdown
Member

No description provided.

pablogsal added the needs backport to 3.11 only security fixes label Jun 10, 2022
AA-Turner reviewed Jun 11, 2022
View reviewed changes
Comment thread Include/pymacro.h Show resolved Hide resolved
Comment thread Include/pymacro.h Outdated Show resolved Hide resolved
Comment thread Include/pymacro.h Show resolved Hide resolved
vstinner approved these changes Jun 13, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

Comment thread Misc/NEWS.d/next/Core and Builtins/2022-06-10-23-41-48.gh-issue-91731.fhYUQG.rst Outdated

vstinner Jun 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

You can move this NEWS entry to Build, or C API, category.

vstinner mentioned this pull request Jun 13, 2022
Closed
Apply suggestions from code review …
8f58dce
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
pablogsal merged commit 65ff27c into python:main Jun 13, 2022

miss-islington commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

pablogsal added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jun 16, 2022

miss-islington commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

pablogsal deleted the 91731 branch June 16, 2022 14:25

bedevere-bot commented Jun 16, 2022

Copy link
Copy Markdown

GH-93907 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.