← 返回首页
gh-91404: Revert "bpo-23689: re module, fix memory leak when a match is terminated by a signal or memory allocation failure (GH-32283)" · Pull Request #93559 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-91404: Revert "bpo-23689: re module, fix memory leak when a match is terminated by a signal or memory allocation failure (GH-32283)"#93559

Closed
ghost wants to merge 2 commits into
mainfrom
unknown repository
Closed

gh-91404: Revert "bpo-23689: re module, fix memory leak when a match is terminated by a signal or memory allocation failure (GH-32283)"#93559
ghost wants to merge 2 commits into
mainfrom
unknown repository

Conversation

ghost commented Jun 7, 2022

Copy link
Copy Markdown

In nesting repeats, a repeat context may have multiple active existences at the same time.
So 6e3eee5's method is wrong.

Revert "bpo-23689: re module, fix memory leak when a match is termina… …
54714b5
…ted by a signal or memory allocation failure (GH-32283)" This reverts commit 6e3eee5.
corona10 added the needs backport to 3.11 only security fixes label Jun 7, 2022
corona10 requested a review from serhiy-storchaka June 7, 2022 05:44
Hello71 mentioned this pull request Jun 15, 2022
Merged
gpshead requested a review from pablogsal June 15, 2022 23:53

gpshead commented Jun 15, 2022

Copy link
Copy Markdown
Member

I created a similar PR as I hadn't seen this one mentioned on the #91404 issue.

At a quick glance without diving deep to compare diffs, the MAGIC constants are not being updated by this PR while I decided to do that in mine.

ghost closed this Jun 16, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka Awaiting requested review from serhiy-storchaka
pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

awaiting review needs backport to 3.11 only security fixes topic-regex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.