← 返回首页
gh-99032: datetime docs: Encoding is no longer relevant by wjandrea · Pull Request #93365 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-99032: datetime docs: Encoding is no longer relevant#93365

Merged
pganssle merged 3 commits into
python:mainfrom
wjandrea:patch-2
Apr 24, 2023
Merged

gh-99032: datetime docs: Encoding is no longer relevant#93365
pganssle merged 3 commits into
python:mainfrom
wjandrea:patch-2

Conversation

wjandrea commented May 30, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The .strftime() methods return a Unicode string as of Python 3.0.

For reference, under the hood, the .strftime() methods use time.strftime(), whose return value is defined here for the current tip of the main branch and here for 3.0.

Please check my work before merging to make sure I've understood what the docs are saying. I'm also not super familiar with C or RST, but I'm quite sure I've understood them correctly.

Backports should be made to all current versions.

BTW, encoding isn't mentioned in the time docs, so no changes required there I don't think.

docs: datetime: Encoding is no longer relevant …
36f3946
The `.strftime()` methods return a Unicode string as of Python 3.0.
wjandrea requested review from abalkin and pganssle as code owners May 30, 2022 22:13
bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 30, 2022

merwok commented Sep 29, 2022

Copy link
Copy Markdown
Member

Could you create a ticket to describe the issue and make it easier to track the fixes? Thanks

nanjekyejoannah reviewed Oct 7, 2022
View reviewed changes

nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I agree, maybe we need an issue to track this.

wjandrea commented Oct 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@merwok @nanjekyejoannah I could open an issue, sure, I'm just not sure what to say beyond what I've written here. Maybe,

The docs say that strftime() will return an encoded string (i.e. bytes), but actually it returns a Unicode string as of Python 3.0 (i.e. str).

Actually, now that I think about it again, maybe it'd be better to change the warning from "may contain Unicode characters encoded ..." to "may contain non-ASCII characters." Say the word and I'll open an issue so we can discuss that.

merwok commented Oct 14, 2022

Copy link
Copy Markdown
Member

That’s just the process we follow to keep things manageable 🙂
A bug report doesn’t have to be very long, if the title is clear and the description tells clearly what the problem is, then we can apply labels to categorize the problem, note all versions that need a fix, people get notified about it, etc.
The issue describes the problem and the PR discussion can focus on the solution. That’s all!

Full details here: https://devguide.python.org/triage/issue-tracker/

wjandrea mentioned this pull request Nov 2, 2022
Closed

Jason-Y-Z commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR. I think you will need to include the issue number in your PR title :)

AlexWaygood changed the title docs: datetime: Encoding is no longer relevant gh-99033: datetime docs: Encoding is no longer relevant Nov 3, 2022
AlexWaygood changed the title gh-99033: datetime docs: Encoding is no longer relevant gh-99032: datetime docs: Encoding is no longer relevant Nov 3, 2022
hugovk removed the needs backport to 3.10 only security fixes label Apr 7, 2023
pganssle requested changes Apr 24, 2023
View reviewed changes
Comment thread Doc/library/datetime.rst Outdated Show resolved Hide resolved

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

abalkin approved these changes Apr 24, 2023
View reviewed changes

abalkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

pganssle merged commit 2aa22f7 into python:main Apr 24, 2023

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @wjandrea for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 24, 2023
pythongh-99032: datetime docs: Encoding is no longer relevant (python… …
50c797a
…GH-93365) This removes a section of the `strftime` and `strptime` documentation that refers to a bygone era when `strftime` would return an encoded byte string. --------- (cherry picked from commit 2aa22f7) Co-authored-by: William Andrea <william.j.andrea@gmail.com> Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com>

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

GH-103788 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 24, 2023
wjandrea deleted the patch-2 branch April 24, 2023 19:00
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
Merge branch 'main' into superopt …
19b8025
* main: (53 commits) pythongh-102498 Clean up unused variables and imports in the email module (python#102482) pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244) pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365) pythongh-94300: Update datetime.strptime documentation (python#95318) pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778) pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456) pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775) Revert "Add tests for empty range equality (python#103751)" (python#103770) pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519) pythonGH-65022: Fix description of copyreg.pickle function (python#102656) pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324) pythongh-91687: modernize dataclass example typing (python#103773) pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747) pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769) pythongh-87452: Improve the Popen.returncode docs Removed unnecessary escaping of asterisks (python#103714) pythonGH-102973: Slim down Fedora packages in the dev container (python#103283) pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095) Add tests for empty range equality (python#103751) pythongh-103712: Increase the length of the type name in AttributeError messages (python#103713) ...
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
Merge branch 'superopt' into superopt_spec …
1972ca4
* superopt: (82 commits) pythongh-101517: fix line number propagation in code generated for except* (python#103550) pythongh-103780: Use patch instead of mock in asyncio unix events test (python#103782) pythongh-102498 Clean up unused variables and imports in the email module (python#102482) pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244) pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365) pythongh-94300: Update datetime.strptime documentation (python#95318) pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778) pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456) pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775) Revert "Add tests for empty range equality (python#103751)" (python#103770) pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519) pythonGH-65022: Fix description of copyreg.pickle function (python#102656) pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324) pythongh-91687: modernize dataclass example typing (python#103773) pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747) pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769) pythongh-87452: Improve the Popen.returncode docs Removed unnecessary escaping of asterisks (python#103714) pythonGH-102973: Slim down Fedora packages in the dev container (python#103283) pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095) ...
JelleZijlstra pushed a commit that referenced this pull request Apr 29, 2023
[3.11] gh-99032: datetime docs: Encoding is no longer relevant (GH-93365 …
9fbb614
) (#103788) This removes a section of the `strftime` and `strptime` documentation that refers to a bygone era when `strftime` would return an encoded byte string. --------- (cherry picked from commit 2aa22f7) Co-authored-by: William Andrea <william.j.andrea@gmail.com> Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

merwok merwok left review comments
pganssle pganssle approved these changes
nanjekyejoannah nanjekyejoannah left review comments
abalkin abalkin approved these changes
AA-Turner AA-Turner approved these changes
+1 more reviewer
DanielNoord DanielNoord approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Footer

© 2026 GitHub, Inc.