← 返回首页
gh-84694: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS by ericsnowcurrently · Pull Request #93185 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-84694: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS#93185

Merged
ericsnowcurrently merged 5 commits into
python:mainfrom
ericsnowcurrently:remove-experiment
May 27, 2022
Merged

gh-84694: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS#93185
ericsnowcurrently merged 5 commits into
python:mainfrom
ericsnowcurrently:remove-experiment

Conversation

ericsnowcurrently commented May 24, 2022

Copy link
Copy Markdown
Member

This was added for bpo-40514 (gh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing:

  • the configure option
  • the macro
  • the code enabled by the macro

vstinner commented May 24, 2022

Copy link
Copy Markdown
Member

I expected that this conditional code would become the default quickly, but I got way more technical issues than expected. I managed to fix many issues: https://vstinner.github.io/isolate-subinterpreters.html

But there are still multiple big issues like static types, singletons or getting the thread state ("tstate") from a thread local storage (TLS). Hopefully, immortal objects may fix static types and singletons, and it seems possible to fix #84702 (tstate).

This experiment was useful to discover all issues and have a better plan to fully implement the feature ("per-interpreter GIL").

corona10 reviewed May 25, 2022
View reviewed changes

corona10 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

If we decide to remove this flag, I would like to recommend adding the entry for What's NEWS.
Although this flag was not intended to expose to the public user, this flag was spread out to users who have interests in the multi-core sub interpreter project.

example: https://stackoverflow.com/a/65995393

kumaraditya303 mentioned this pull request May 25, 2022
Closed

kumaraditya303 commented May 25, 2022

Copy link
Copy Markdown
Contributor

This is also broken on main branch and 3.11 as it won't even compile with this option. See #90988

markshannon commented May 25, 2022

Copy link
Copy Markdown
Member

Yes, please.
EXPERIMENTAL_ISOLATED_SUBINTERPRETERS was an interesting experiment, but it's done.

ericsnowcurrently commented May 25, 2022

Copy link
Copy Markdown
Member Author

@pablogsal, would it be okay to backport this to 3.11? (It already doesn't work on 3.11 currently.)

pablogsal commented May 26, 2022

Copy link
Copy Markdown
Member

Yep, I'm ok backporting this 👍

ericsnowcurrently merged commit caa279d into python:main May 27, 2022
ericsnowcurrently deleted the remove-experiment branch May 27, 2022 23:38
ericsnowcurrently added the needs backport to 3.11 only security fixes label May 27, 2022

miss-islington commented May 27, 2022

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented May 27, 2022

Copy link
Copy Markdown
Contributor

Sorry, @ericsnowcurrently, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker caa279d6fd5f151e57f891cd4f6ba51b532501c6 3.11

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2022
Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS (cherry-picked GH-pythongh… …
f9a33b0
…-93185) This was added for bpo-40514 (pythongh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing: * the configure option * the macro * the code enabled by the macro
miss-islington pushed a commit that referenced this pull request May 28, 2022
[3.11] bpo-40514: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS (gh-93185)… …
3637425
… (GH-93306) (cherry picked from commit caa279d) This was added for bpo-40514 (gh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing: * the configure option * the macro * the code enabled by the macro Automerge-Triggered-By: GH:ericsnowcurrently
This was referenced Jul 10, 2022
Closed
Closed
CAM-Gerlach added a commit to CAM-Gerlach/cpython that referenced this pull request Oct 16, 2022
Add subinterpreters removal from issue pythongh-84694 PRs pythongh-93185 …
1790ddd
/ pythongh-93306 Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
CAM-Gerlach mentioned this pull request Oct 16, 2022
Merged
miss-islington pushed a commit that referenced this pull request Oct 17, 2022
gh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (GH-98345) …
5fe0431
Part of #95913 Forward port of #93306, which was a backport of #93185, to address #84694 This adds the What's New entry for the removal of the subinterpreter-related env variable, build-time flag, etc. As @ericsnowcurrently was author of the original changes, I added him as a co-author to the commit. This addition to the Python 3.11 What's New document were only made to the Python 3.11 branch during the backport process, and not added to the version in `main`. Forward-porting it ensures the docs retain these additions for the future, rather than being lost in a legacy Python versions, allows it to be be edited as part of #95913 , and avoids merge conflicts with routine back-ports of PRs touching it. I've pulled in the addition exactly as-is with no modifications; any editing will be done in future PRs (and therefore can be reviewed and backported accordingly). The one other such addition is forward-ported in #98344
corona10 mentioned this pull request Oct 21, 2022
Closed
terryjreedy changed the title bpo-40514: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS gh-84694: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS Feb 18, 2025
terryjreedy removed the needs backport to 3.11 only security fixes label Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 left review comments
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

ericsnowcurrently

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Footer

© 2026 GitHub, Inc.