← 返回首页
gh-92547: Remove deprecated sqlite3 features by erlend-aasland · Pull Request #92548 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-92547: Remove deprecated sqlite3 features#92548

Merged
erlend-aasland merged 5 commits into
mainfrom
sqlite-remove-deprecated-features
May 16, 2022
Merged

gh-92547: Remove deprecated sqlite3 features#92548
erlend-aasland merged 5 commits into
mainfrom
sqlite-remove-deprecated-features

Conversation

erlend-aasland commented May 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com

Closes #92547

gh-92547: Remove deprecated sqlite3 features …
8312697
The following sqlite3 features were deprecated in 3.10, scheduled for removal in 3.12: - sqlite3.OptimizedUnicode (gh-23163) - sqlite3.enable_shared_cache (gh-24008) Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
JelleZijlstra approved these changes May 10, 2022
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

erlend-aasland commented May 13, 2022

Copy link
Copy Markdown
Contributor Author

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

FTR, nltk/nltk#3000 was just merged.

JelleZijlstra commented May 16, 2022

Copy link
Copy Markdown
Member

Feel free to merge!

erlend-aasland merged commit 00f22e8 into main May 16, 2022
erlend-aasland deleted the sqlite-remove-deprecated-features branch May 16, 2022 17:52

erlend-aasland commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for helping, Jelle and Victor!

erlend-aasland mentioned this pull request May 16, 2022
Closed

vstinner commented May 17, 2022

Copy link
Copy Markdown
Member

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared: 00f22e8

Would you mind to copy these information in What's New in Python 3.12?

erlend-aasland commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared: 00f22e8

Would you mind to copy these information in What's New in Python 3.12?

Yes, I'll amend What's New. Thanks for the heads-up!

erlend-aasland commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

Would you mind to copy these information in What's New in Python 3.12?

Something like this? #93872

vstinner commented Jun 16, 2022

Copy link
Copy Markdown
Member

Something like this? #93872

That's very valuable, thanks.

donbarbos added a commit to donbarbos/typeshed that referenced this pull request Mar 29, 2026
[sqlite3] Deprecate undocumented enable_shared_cache …
7d91fcb
Source: python/cpython#92548
donbarbos mentioned this pull request Mar 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
berkerpeksag Awaiting requested review from berkerpeksag
serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3: remove features deprecated in 3.10

4 participants

Footer

© 2026 GitHub, Inc.