← 返回首页
gh-90765: Catch LegacyInterpolation deprecation warning by hugovk · Pull Request #91480 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-90765: Catch LegacyInterpolation deprecation warning#91480

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
hugovk:issue45173-deprecate-LegacyInterpolation2
May 2, 2022
Merged

gh-90765: Catch LegacyInterpolation deprecation warning#91480
JelleZijlstra merged 1 commit into
python:mainfrom
hugovk:issue45173-deprecate-LegacyInterpolation2

Conversation

hugovk commented Apr 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Follow on from gh-90765, see #30927 (comment).

Before

$ PYTHONWARNINGS=always ./python.exe -Wall -m test test_configparser Raised RLIMIT_NOFILE: 256 -> 1024 0:00:00 load avg: 5.65 Run tests sequentially 0:00:00 load avg: 5.65 [1/1] test_configparser /Users/huvankem/github/cpython/Lib/test/test_configparser.py:1031: DeprecationWarning: LegacyInterpolation has been deprecated since Python 3.2 and will be removed from the configparser module in Python 3.13. Use BasicInterpolation or ExtendedInterpolation instead. interpolation = configparser.LegacyInterpolation() == Tests result: SUCCESS == 1 test OK. Total duration: 476 ms Tests result: SUCCESS

After

$ PYTHONWARNINGS=always ./python.exe -Wall -m test test_configparser Raised RLIMIT_NOFILE: 256 -> 1024 0:00:00 load avg: 5.67 Run tests sequentially 0:00:00 load avg: 5.67 [1/1] test_configparser == Tests result: SUCCESS == 1 test OK. Total duration: 468 ms Tests result: SUCCESS

hugovk force-pushed the issue45173-deprecate-LegacyInterpolation2 branch from 1aefad5 to b820cd5 Compare April 12, 2022 11:11

ghost commented Apr 12, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Apr 12, 2022
hugovk changed the title bpo-46607: Catch LegacyInterpolation deprecation warning gh-90765: Catch LegacyInterpolation deprecation warning Apr 12, 2022
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation2 branch from b820cd5 to 27d64de Compare April 12, 2022 11:12
hugovk mentioned this pull request Apr 12, 2022
Merged
hugovk requested a review from tirkarthi April 12, 2022 11:14

hugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

@tirkarthi Does this need a news file or skip-news label?

tirkarthi approved these changes Apr 12, 2022
View reviewed changes

tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM. Thanks @hugovk .

AlexWaygood commented Apr 12, 2022

Copy link
Copy Markdown
Member

All commit authors signed the Contributor License Agreement.

@ambv any idea why the CLA CI check is red, even though the comment here says it's green?

hugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

I have already signed the old CLA. When I first created the PR, the CLA comment was red:

So I clicked the link to sign the new one anyway. It turned the comment green but not the check:

ambv closed this Apr 14, 2022
ambv reopened this Apr 14, 2022
JelleZijlstra merged commit 56f9844 into python:main May 2, 2022
hugovk deleted the issue45173-deprecate-LegacyInterpolation2 branch May 2, 2022 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tirkarthi tirkarthi approved these changes

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.