← 返回首页
bpo-32604: Improve subinterpreter tests. by ericsnowcurrently · Pull Request #6914 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-32604: Improve subinterpreter tests.#6914

Merged
ericsnowcurrently merged 18 commits into
python:masterfrom
ericsnowcurrently:interpreters-tests
May 16, 2018
Merged

bpo-32604: Improve subinterpreter tests.#6914
ericsnowcurrently merged 18 commits into
python:masterfrom
ericsnowcurrently:interpreters-tests

Conversation

ericsnowcurrently commented May 16, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Add more tests for subinterpreters. This patch also fixes a few small defects in the channel implementation.

https://bugs.python.org/issue32604

Convert channel IDs into channels when shared.
828a227
Only convert channel IDs when requested.
bac0f12
channel_drop_interpreter -> channel_release.
5242a34
Organize tests.
7b2407d
Fix function signatures.
6a5d1fc
Add InterpreterID/ChannelID.__str__().
c34ff90
Return an InterpreterID from get_main().
cbbc562
Add support for int.
49e8065
Correctly handle \x00 when sharing bytes.
cb41fa5
Test channel_close() across a broad spectrum of cases.
13e6b7a
Fix a typo.
2ee8cb0
Add an exhaustive set of permutated tests for close_channel().
ecb5834
Fix run_action() for close operations.
262e53e
Skip the exhaustive tests.
7028808
Add a note about lookup of cross-interpreter types.
5479620
Add support for str.
13c51d4
Move the normal channel_close() tests.
4cf75a2
Do not mask errors in _channel_recv().
bffbbfc
ericsnowcurrently merged commit 6d2cd90 into python:master May 16, 2018

bedevere-bot commented May 16, 2018

Copy link
Copy Markdown

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!

ericsnowcurrently deleted the interpreters-tests branch May 16, 2018 20:46
This was referenced May 30, 2018
Merged
Merged
ericsnowcurrently added a commit that referenced this pull request May 31, 2018
bpo-33615: Temporarily disable a test that is triggering crashes on a… …
110bc01
… few buildbots. (gh-7288) For bpo-32604 I added some subinterpreter-related tests (see #6914) that are causing crashes on a few buildbots. I'm working on fixing the crashes (see #7251). This change temporarily disables the triggering test.
ericsnowcurrently mentioned this pull request Jun 1, 2018
Merged
ericsnowcurrently added a commit that referenced this pull request Jun 2, 2018
bpo-33615: Re-enable a subinterpreter test. (gh-7251) …
6379913
For bpo-32604 I added extra subinterpreter-related tests (see #6914), which caused a few buildbots to crash. This patch fixes the crash by ensuring that refcounts in channels are handled properly.
ericsnowcurrently mentioned this pull request Aug 24, 2018
Closed
ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.