← 返回首页
bpo-32604: Swap threads only if the interpreter is different. by ericsnowcurrently · Pull Request #5778 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-32604: Swap threads only if the interpreter is different.#5778

Merged
ericsnowcurrently merged 2 commits into
python:masterfrom
ericsnowcurrently:fix-thread-swap-same-interpreter
Feb 20, 2018
Merged

bpo-32604: Swap threads only if the interpreter is different.#5778
ericsnowcurrently merged 2 commits into
python:masterfrom
ericsnowcurrently:fix-thread-swap-same-interpreter

Conversation

ericsnowcurrently commented Feb 20, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The CPython runtime assumes that there is a one-to-one relationship (for a given interpreter) between PyThreadState and OS threads. Sending and receiving on a channel in the same interpreter was causing crashes because of this (specifically due to a check in PyThreadState_Swap()). The solution is to not switch threads if the interpreter is the same.

https://bugs.python.org/issue32604

ericsnowcurrently merged commit f53d9f2 into python:master Feb 20, 2018

miss-islington commented Feb 20, 2018

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2018
bpo-32604: Swap threads only if the interpreter is different. (python… …
2f3f233
…gh-5778) The CPython runtime assumes that there is a one-to-one relationship (for a given interpreter) between PyThreadState and OS threads. Sending and receiving on a channel in the same interpreter was causing crashes because of this (specifically due to a check in PyThreadState_Swap()). The solution is to not switch threads if the interpreter is the same. (cherry picked from commit f53d9f2) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>

bedevere-bot commented Feb 20, 2018

Copy link
Copy Markdown

GH-5783 is a backport of this pull request to the 3.7 branch.

ericsnowcurrently deleted the fix-thread-swap-same-interpreter branch February 20, 2018 23:32
ericsnowcurrently mentioned this pull request Aug 24, 2018
Closed
ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.