← 返回首页
[3.7] bpo-32604: Make _xxsubinterpreters build on Windows (GH-5516) by miss-islington · Pull Request #5624 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.7] bpo-32604: Make _xxsubinterpreters build on Windows (GH-5516)#5624

Merged
zware merged 1 commit into
python:3.7from
miss-islington:backport-310b052-3.7
Feb 11, 2018
Merged

[3.7] bpo-32604: Make _xxsubinterpreters build on Windows (GH-5516)#5624
zware merged 1 commit into
python:3.7from
miss-islington:backport-310b052-3.7

Conversation

miss-islington commented Feb 11, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This is not the ideal solution; this means that a test module is now
always included in the main python3x.dll. However, we're already
including xxsubtype, so why not?
(cherry picked from commit 310b052)

Co-authored-by: Zachary Ware zachary.ware@gmail.com

https://bugs.python.org/issue32604

bpo-32604: Make _xxsubinterpreters build on Windows (pythonGH-5516) …
af5d2df
This is not the ideal solution; this means that a test module is now always included in the main python3x.dll. However, we're already including xxsubtype, so why not? (cherry picked from commit 310b052) Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
miss-islington requested a review from a team as a code owner February 11, 2018 16:44
bedevere-bot mentioned this pull request Feb 11, 2018
Merged

miss-islington commented Feb 11, 2018

Copy link
Copy Markdown
Contributor Author

@zware: Backport status check is done, and it's a success ✅ .

zware merged commit fe61e8d into python:3.7 Feb 11, 2018

miss-islington commented Feb 11, 2018

Copy link
Copy Markdown
Contributor Author

Thanks, @zware!

miss-islington deleted the backport-310b052-3.7 branch February 11, 2018 17:16
ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.