← 返回首页
bpo-32604: Make _xxsubinterpreters build on Windows by zware · Pull Request #5516 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-32604: Make _xxsubinterpreters build on Windows#5516

Merged
zware merged 1 commit into
python:masterfrom
zware:temp_add_xxsubinterpreters
Feb 11, 2018
Merged

bpo-32604: Make _xxsubinterpreters build on Windows#5516
zware merged 1 commit into
python:masterfrom
zware:temp_add_xxsubinterpreters

Conversation

zware commented Feb 3, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This is not the ideal solution; this means that a test module is now
always included in the main python3x.dll. However, we're already
including xxsubtype, so why not? It at least gets the code tested.

https://bugs.python.org/issue32604

bpo-32604: Make _xxsubinterpreters build on Windows …
6d5fa8f
This is not the ideal solution; this means that a test module is now always included in the main python3x.dll. However, we're already including xxsubtype, so why not?
zware requested a review from a team as a code owner February 3, 2018 20:23
zware merged commit 310b052 into python:master Feb 11, 2018

miss-islington commented Feb 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

zware deleted the temp_add_xxsubinterpreters branch February 11, 2018 16:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2018
bpo-32604: Make _xxsubinterpreters build on Windows (pythonGH-5516) …
af5d2df
This is not the ideal solution; this means that a test module is now always included in the main python3x.dll. However, we're already including xxsubtype, so why not? (cherry picked from commit 310b052) Co-authored-by: Zachary Ware <zachary.ware@gmail.com>

bedevere-bot commented Feb 11, 2018

Copy link
Copy Markdown

GH-5624 is a backport of this pull request to the 3.7 branch.

zware mentioned this pull request Feb 11, 2018
Closed
ericsnowcurrently mentioned this pull request Aug 24, 2018
Closed
ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently Awaiting requested review from ericsnowcurrently
zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.