← 返回首页
bpo-32604: Fix memory leaks in the new _xxsubinterpreters module. by ericsnowcurrently · Pull Request #5507 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-32604: Fix memory leaks in the new _xxsubinterpreters module.#5507

Merged
ericsnowcurrently merged 19 commits into
python:masterfrom
ericsnowcurrently:fix-refleaks-interpreters-module
Feb 3, 2018
Merged

bpo-32604: Fix memory leaks in the new _xxsubinterpreters module.#5507
ericsnowcurrently merged 19 commits into
python:masterfrom
ericsnowcurrently:fix-refleaks-interpreters-module

Conversation

ericsnowcurrently commented Feb 3, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This also fixes the 2 coverity-reported defects.

https://bugs.python.org/issue32604

DECREF cls in _PyCrossInterpreterData_Lookup().
e12d641
DECREF the id in interp_list_all().
ce72eef
Avoid raising RunFailedError.
27bbab7
DECREF id in _coerce_id().
c744873
DECREF the original error message.
e982d87
Do not explicitly check against INT64_MAX.
aac9485
Free cids when done.
35f6046
DECREF other in channelid_richcompare().
38d924e
Add items to non-empty channels.
4321ecf
Add struct _sharedns and isolate related memory ops.
e5a3515
Clean up memory ops for _sharedexception.
0c0fa3d
Clean up _PyChannelState memory ops.
f0d4430
Add _channelref_free().
4802046
Move the RunFailedError definition down.
ac7bad5
Do not INCREF after PyErr_Fetch().
0689a9c
DECREF the exception name.
9a91a28
Free the channel when we close it.
654e59a
Free the data when we are done with it.
8ca3c96
DECREF the ID in channelid_hash().
702876b
ericsnowcurrently merged commit 4e9da0d into python:master Feb 3, 2018

bedevere-bot commented Feb 3, 2018

Copy link
Copy Markdown

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!

ericsnowcurrently deleted the fix-refleaks-interpreters-module branch February 3, 2018 04:49

miss-islington commented Feb 3, 2018

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

bedevere-bot commented Feb 3, 2018

Copy link
Copy Markdown

GH-5509 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2018
bpo-32604: Fix memory leaks in the new _xxsubinterpreters module. (py… …
baa9fd9
…thonGH-5507) (cherry picked from commit 4e9da0d) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently added a commit that referenced this pull request Feb 3, 2018
bpo-32604: Fix memory leaks in the new _xxsubinterpreters module. (GH… …
f33eced
…-5507) (cherry picked from commit 4e9da0d) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently mentioned this pull request Aug 24, 2018
Closed
ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.