← 返回首页
bpo-13553: Document tkinter.Tk args by csabella · Pull Request #4786 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-13553: Document tkinter.Tk args#4786

Merged
JelleZijlstra merged 8 commits into
python:mainfrom
csabella:bpo13553
May 10, 2022
Merged

bpo-13553: Document tkinter.Tk args#4786
JelleZijlstra merged 8 commits into
python:mainfrom
csabella:bpo13553

Conversation

csabella commented Dec 11, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

serhiy-storchaka reviewed Dec 11, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
terryjreedy requested changes Dec 12, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved

bedevere-bot commented Dec 12, 2017

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

terryjreedy commented Dec 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

None of my comments are outdated by applying Serhiy's suggestions. My review just happened to start before the patch arrived, and except for 1, happen to be attached to the same sentences. Serhiy, please also review my comments.

serhiy-storchaka reviewed Dec 12, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
vstinner reviewed Dec 12, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst
Specifies that the main window for the application is to be embedded in
the window whose identifier is given, instead of being created as an
independent toplevel window.

vstinner Dec 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

While we are documenting the Tk class. Would it be worth it to document Tk attributes? master, children and tk.

csabella Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

The current page reads more like a 'getting started' or 'how to', so I wasn't sure how much detail to add. I know there's a separate bug issue where Terry figured out the difference between master and parent, so maybe it would be worthwhile to include that here?

Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved

csabella commented Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

bedevere-bot commented Dec 12, 2017

Copy link
Copy Markdown

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

vstinner reviewed Dec 12, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved

csabella commented Dec 14, 2017

Copy link
Copy Markdown
Contributor Author

@terryjreedy @serhiy-storchaka @vstinner
I've made additional changes to document the attributes and to remove the documentation of readprofile. Thanks!

vstinner reviewed Dec 15, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
Comment thread Doc/library/tkinter.rst Outdated Show resolved Hide resolved
vadmium reviewed Dec 16, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Show resolved Hide resolved
terryjreedy previously approved these changes Feb 2, 2018
View reviewed changes
terryjreedy closed this Feb 2, 2018
terryjreedy reopened this Feb 2, 2018
37 hidden items Load more…

vstinner commented Jan 10, 2019

Copy link
Copy Markdown
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

JulienPalard commented Sep 13, 2019

Copy link
Copy Markdown
Member

@csabella Looks like this PR is almost OK, maybe just missing the mention that className permits to choose the title of the window (last message of Mark). I tried to mark as resolved every actually resolved comments, I'll let you read the rest of them a last time.

JelleZijlstra approved these changes May 8, 2022
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Looks good, it seems the remaining comments don't need to be blocking.

JelleZijlstra self-assigned this May 8, 2022

JelleZijlstra commented May 8, 2022

Copy link
Copy Markdown
Member

Planning to merge this unless someone has further comments.

taleinat commented May 9, 2022

Copy link
Copy Markdown
Contributor

LGTM

JelleZijlstra merged commit c56e2bb into python:main May 10, 2022

miss-islington commented May 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
bpo-13553: Document tkinter.Tk args (pythonGH-4786) …
8d836f4
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92593 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels May 10, 2022

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92594 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
bpo-13553: Document tkinter.Tk args (pythonGH-4786) …
e79711c
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92595 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
bpo-13553: Document tkinter.Tk args (pythonGH-4786) …
cf1f27a
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request May 10, 2022
bpo-13553: Document tkinter.Tk args (GH-4786) …
74c094d
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request May 10, 2022
bpo-13553: Document tkinter.Tk args (GH-4786) …
b7a8786
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request May 10, 2022
bpo-13553: Document tkinter.Tk args (GH-4786) …
5ed2f11
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
bpo-13553: Document tkinter.Tk args (pythonGH-4786) …
d5b0a60
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
hauntsaninja mentioned this pull request Oct 29, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
vadmium vadmium left review comments
serhiy-storchaka serhiy-storchaka left review comments
JulienPalard JulienPalard approved these changes
taleinat taleinat approved these changes
JelleZijlstra JelleZijlstra approved these changes
terryjreedy terryjreedy left review comments
+1 more reviewer
roseman roseman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

JelleZijlstra

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Footer

© 2026 GitHub, Inc.